boards/native: Remove macOS as native target #18735
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Teufelchen1
requested review from
leandrolanzieri,
jia200x,
MrKevinWeiss and
aabadie
as code owners
miri64
reviewed
Oct 13, 2022
Makefile.include
Outdated
Comment on lines
208
to
213
| # If native, TOOLCHAIN for OSX is llvm | ||
| ifeq ($(BOARD),native) | ||
| ifeq ($(OS),Darwin) | ||
| TOOLCHAIN ?= llvm | ||
| endif | ||
| endif |
There was a problem hiding this comment.
Maybe keep this, but add an error message instead of setting the toolchain instead to mitigate some confused forum questions?
ifeq ($(BOARD),native)
ifeq ($(OS),Darwin)
$(shell $(COLOR_ECHO) "$(COLOR_RED)"Buildin on macOS is not supported."\
"We recommend vagrant for building:$(COLOR_RESET)"\
"https://github.com/RIOT-OS/RIOT/blob/master/dist/tools/vagrant/README.md 1>&2)
endif
endifThere was a problem hiding this comment.
I implemented your suggestion. Still builds on my linux machine. On macOS, the error is printed but it still tries to build the application (which then fails ofc).
See e.g #14631 for the state of that. |
Teufelchen1
force-pushed
the
chore/native_macos
branch
from
ea49113 to
c187f87
Compare
github-actions
bot
added
Area: build system
miri64
reviewed
Oct 25, 2022
Makefile.include
Outdated
| ifeq ($(BOARD),native) | ||
| ifeq ($(OS),Darwin) | ||
| TOOLCHAIN ?= llvm | ||
| $(shell $(COLOR_ECHO) "$(COLOR_RED)"Buildin on macOS is not supported."\ | ||
| "We recommend vagrant for building:$(COLOR_RESET)"\ |
There was a problem hiding this comment.
No mixing tabs and spaces ;-P
Suggested change
| "We recommend vagrant for building:$(COLOR_RESET)"\ | |
| "We recommend vagrant for building:$(COLOR_RESET)"\ |
Teufelchen1
force-pushed
the
chore/native_macos
branch
from
c187f87 to
35a06c4
Compare
miri64
added
the
CI: ready for build
miri64
approved these changes
Oct 25, 2022
Murdock results✔️ PASSED 35a06c4 boards/native: Remove macOS as native target
ArtifactsThis only reflects a subset of all builds from https://ci-prod.riot-os.org. Please refer to https://ci.riot-os.org for a complete build for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi! 👋
Since building for macOS native is broken for a loooong time now and fixing it is far from trivial;
This removes building for macOS native.
It still builds for Linux on my machine. Please double check that and can somebody test the freebsd target?
How and where would one add an info message for macOS users who try to build native? Do we even want that?