Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests/pbkdf2: remove unused #include #18943

Merged
merged 1 commit into from
Nov 22, 2022
Merged

tests/pbkdf2: remove unused #include #18943

merged 1 commit into from
Nov 22, 2022

Conversation

maribu
Copy link
Member

@maribu maribu commented Nov 21, 2022

Contribution description

What the title says.

Testing procedure

Should not result in changes in binaries. And Murdock should give green light.

Issues/PRs references

The removed #include caused issues in a backport, but it is actually uneeded in master as well. I cannot recall why it was there in the first place - maybe a leftover from the flaky test?

@github-actions github-actions bot added the Area: tests Area: tests and testing framework label Nov 21, 2022
@maribu maribu added Impact: minor The PR is small in size and might only require a quick look of a knowledgeable reviewer Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Nov 21, 2022
@maribu
Copy link
Member Author

maribu commented Nov 21, 2022

This will be one of the PRs that can_fast_ci_run.py should speed up :)

aabadie
aabadie approved these changes Nov 21, 2022
View reviewed changes
Copy link
Contributor

@aabadie aabadie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@riot-ci
Copy link

riot-ci commented Nov 21, 2022 •
edited
Loading

Murdock results

✔️ PASSED

b1da816 tests/pbkdf2: remove unused #include

Success Failures Total Runtime
245 0 246 03m:15s

Artifacts

@benpicco benpicco merged commit 2be0276 into RIOT-OS:master Nov 22, 2022
@kaspar030 kaspar030 added this to the Release 2023.01 milestone Jan 19, 2023
@maribu maribu deleted the tests/pbkdf2 branch April 25, 2023 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aabadie aabadie aabadie approved these changes

@smlng smlng Awaiting requested review from smlng

@leandrolanzieri leandrolanzieri Awaiting requested review from leandrolanzieri leandrolanzieri is a code owner

@MichelRottleuthner MichelRottleuthner Awaiting requested review from MichelRottleuthner MichelRottleuthner is a code owner

@fjmolinas fjmolinas Awaiting requested review from fjmolinas

Assignees
No one assigned
Labels
Area: tests Area: tests and testing framework CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Impact: minor The PR is small in size and might only require a quick look of a knowledgeable reviewer Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation
Projects
None yet
Milestone
Release 2023.01
Development

Successfully merging this pull request may close these issues.
5 participants
@maribu @riot-ci @aabadie @benpicco @kaspar030