-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cpu/gd32v: add periph_spi support #19214
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gschorcht
requested review from
leandrolanzieri,
jia200x and
MrKevinWeiss
as code owners
January 30, 2023 07:25
gschorcht
changed the title
cpu/gd32v: add periph spi support
cpu/gd32v: add periph_spi support
Jan 30, 2023
github-actions
bot
added
Area: boards
Area: Board ports
Area: cpu
Area: CPU/MCU ports
Area: doc
Area: Documentation
Area: Kconfig
Area: Kconfig integration
Area: tools
Area: Supplementary tools
labels
Jan 30, 2023
gschorcht
force-pushed
the
cpu/gd32v/periph_spi
branch
from
January 30, 2023 07:26
236c16c
to
dee714d
Compare
gschorcht
added
Type: new feature
The issue requests / The PR implemements a new feature for RIOT
CI: ready for build
If set, CI server will compile all applications for all available boards for the labeled PR
Platform: RISC-V
Platform: This PR/issue effects RISC-V-based platforms
labels
Jan 30, 2023
benpicco
reviewed
Jan 30, 2023
gschorcht
added
the
State: waiting for other PR
State: The PR requires another PR to be merged first
label
Jan 30, 2023
benpicco
removed
the
State: waiting for other PR
State: The PR requires another PR to be merged first
label
Jan 31, 2023
github-actions
bot
removed
the
Platform: RISC-V
Platform: This PR/issue effects RISC-V-based platforms
label
Jan 31, 2023
benpicco
approved these changes
Jan 31, 2023
please squash |
gschorcht
force-pushed
the
cpu/gd32v/periph_spi
branch
from
January 31, 2023 20:07
a48e2cb
to
ec66e3e
Compare
bors merge |
Merge conflict. |
gschorcht
force-pushed
the
cpu/gd32v/periph_spi
branch
from
February 1, 2023 01:45
ec66e3e
to
929bb3e
Compare
bors merge |
🕐 Waiting for PR status (GitHub check) to be set, probably by CI. Bors will automatically try to run when all required PR statuses are set. |
bors merge |
Build succeeded: |
Thanks for reviewing and merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Area: boards
Area: Board ports
Area: cpu
Area: CPU/MCU ports
Area: doc
Area: Documentation
Area: Kconfig
Area: Kconfig integration
Area: tools
Area: Supplementary tools
CI: ready for build
If set, CI server will compile all applications for all available boards for the labeled PR
Type: new feature
The issue requests / The PR implemements a new feature for RIOT
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution description
This PR provides the
periph_spi
support and is one of a bunch of PRs that complete the peripheral drivers for GD32VF103.The driver is a modified version of the driver for STM32F1 with some changes that were necessary to get it working on GD32V.
Testing procedure
tests/periph_spi
as well as a test with any SPI sensor should work.tests/driver_sdcard_spi
should work onsipeed-longan-nano
.Issues/PRs references
Depeneds on PR #19216