-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
boards/weact-f4x1cx: enable tinyUSB #19275
Conversation
@@ -16,6 +16,7 @@ config BOARD_COMMON_WEACT_F4X1CX | |||
select HAS_PERIPH_TIMER | |||
select HAS_PERIPH_UART | |||
select HAS_PERIPH_USBDEV | |||
select HAS_TINYUSB_DEVICE |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Kconfig won't be happy with this. This board and all the other boards with a signle USB interface were part of PR #18998 where I also changed the approach of the STDIO backend selection for Kconfig in commit b2c855a.
But with the current approach of STDIO selection we would have to use the selection as for stm32f4discovery
or esp32s-wemos-mini
dependent on what the default selection should be.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah true it's the problem again that would require a weact-f4x1cx.conf
just to make Kconfig CI happy but without solving the issue on the Kconfig side.
closed in favor of #18998 |
I can always just set |
Why not to solve it for now like for select HAS_HIGHLEVEL_STDIO
+ select MODULE_USBUS_CDC_ACM if TEST_KCONFIG && MODULE_USBUS
+ select PACKAGE_TINYUSB if TEST_KCONFIG && !MODULE_USBUS
+
+ choice STDIO_IMPLEMENTATION
+ default MODULE_STDIO_CDC_ACM if MODULE_USBUS
+ default MODULE_STDIO_TINYUSB_CDC_ACM if PACKAGE_TINYUSB
+ endchoice |
My only concern is that we will also have to clean up all those one-off selections once we have a general solution… |
Contribution description
The MCU already has tinyUSB support, we only need to mark it as available in the board, together with
periph_usbdev
. (Ideally this should just be a single USB port feature on which bothperiph_usbdev
andtinyusb_device
depend).Testing procedure
Issues/PRs references