cpu/esp32: fix compilation issues with GCC 12.2 [backport 2023.04] #19561
Conversation
kaspar030
added
Area: build system
|
@MrKevinWeiss please take a look at this. We're having a riotdocker chicken-and-egg, RIOT-OS/riotdocker#227 needs #19450 to pass, but riotdocker needs to stay compatible with the latest release (so backport PRs still pass). @gschorcht and I discussed how to fix this. Other than waiting until the next release branch is split (which would painfully stall Gunar for up to two months), backporting this toolchain fix PR seems like the best option. |
|
Would this also mean we need a point release? I guess it would be able to just take the release branch... |
|
We can merge the backport but before release I would like to run the easy automated tests and rerun the board tests on the esp. |
|
bors merge |
19561: cpu/esp32: fix compilation issues with GCC 12.2 [backport 2023.04] r=MrKevinWeiss a=kaspar030 # Backport of #19450 ### Contribution description This PR provides the changes in `cpu/esp32` and `cpu/esp_common` to fix the compilation issues with GCC v12.2. It is required as the first step in the preparation of the upgrade to ESP-IDF version 5.1. **Please note**: Insead of fixing the ESP-IDF 4.4 code itself by a big bunch of patches to fix the compilation problems with GCC v12.2, it temporarily disables some warnings. The reason is that the ESP-IDF 5.1 requires GCC v12.2 and should be fixed for this compiler version by the vendor. ### Testing procedure Green CI The change were already tested with all ESP-specific modules like `esp_now`, `esp_wifi`, `esp_spi` and `esp_ble` for all supported ESP platforms. ### Issues/PRs references Prerequisite for RIOT-OS/riotdocker#227 Fixes issue #19421 Co-authored-by: Gunar Schorcht <gunar@schorcht.net>
|
Build failed: |
I don't think we need a point release. Those we do if there's "critical" stuff. |
Sorry for just adding a 👍 to a comment that states two alternatives.
This is what the 👍 was directed at ;) |
|
Hrmpf, looks like this trips over the codespell update. I guess we'll have to backport #19528, too. |
2 similar comments
|
Hrmpf, looks like this trips over the codespell update. I guess we'll have to backport #19528, too. |
|
Hrmpf, looks like this trips over the codespell update. I guess we'll have to backport #19528, too. |
I thought it would need it to fix the docker latest issue? |
|
See #19563, which I guess needs to be in first... |
|
bors merge |
|
Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page. |
Backport of #19450
Contribution description
This PR provides the changes in
cpu/esp32andcpu/esp_commonto fix the compilation issues with GCC v12.2. It is required as the first step in the preparation of the upgrade to ESP-IDF version 5.1.Please note: Insead of fixing the ESP-IDF 4.4 code itself by a big bunch of patches to fix the compilation problems with GCC v12.2, it temporarily disables some warnings. The reason is that the ESP-IDF 5.1 requires GCC v12.2 and should be fixed for this compiler version by the vendor.
Testing procedure
Green CI
The change were already tested with all ESP-specific modules like
esp_now,esp_wifi,esp_spiandesp_blefor all supported ESP platforms.Issues/PRs references
Prerequisite for RIOT-OS/riotdocker#227
Fixes issue #19421