tests/pkg/minmea: adding GGA, GSA and RMC sentences to test application #20005
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jan-mo
requested review from
smlng,
leandrolanzieri,
aabadie,
MichelRottleuthner and
fjmolinas
as code owners
jan-mo
force-pushed
the
feat/20231020__adapting_nmea_message_test
branch
from
3a447aa to
425a47b
Compare
benpicco
added
the
CI: ready for build
|
You also want to update (You can test this by running |
benpicco
reviewed
Oct 20, 2023
jan-mo
force-pushed
the
feat/20231020__adapting_nmea_message_test
branch
from
425a47b to
20cf475
Compare
jan-mo
force-pushed
the
feat/20231020__adapting_nmea_message_test
branch
from
20cf475 to
d569cdf
Compare
benpicco
approved these changes
Oct 23, 2023
|
bors merge |
|
Build failed: |
|
Ah bors merge |
|
Build failed: |
|
bors merge |
|
🔒 Permission denied Existing reviewers: click here to make jan-mo a reviewer |
|
bors merge |
|
🕐 Waiting for PR status (GitHub check) to be set, probably by CI. Bors will automatically try to run when all required PR statuses are set. |
|
Build failed: |
jan-mo
force-pushed
the
feat/20231020__adapting_nmea_message_test
branch
from
14464dc to
bdb1bc3
Compare
|
bors |
|
bors merge |
|
Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page.
|
|
test work on native with TZ set to GMT-1
https://ci.riot-os.org/details/99a40c1ff07f43a6b985a7ac3a135cf0/builds/tests:pkg:minmea vs https://ci.riot-os.org/details/9023c32a91604a4689dea69acda5ac27 |
|
Yes I would strongly assume that it is dependent on the time zone you set on native. The RMC is given the time in UTC and in DDMMYY and hhmmss.ss. See here https://docs.novatel.com/OEM7/Content/Logs/GPRMC.htm |
|
We can also only check the date and time in the RMC message, so it will not be converted to an actual timestamp. I will create a follow up PR on that. |
bors bot
added a commit
that referenced
this pull request
Oct 27, 2023
19932: tests/periph: Add test using the Peripheral Selftest Shield r=benpicco a=maribu
### Contribution description
This adds a test that makes use of the peripheral selftesting shield.
#### ToDo
- [x] Add doc
### Testing procedure
- grab an Arduino UNO compatible board that has the Arduino pin map feature
- connect it to the testing shield
- configure the testing shield
- make sure the VCC selector matches the logic level of the board (3.3V and 5V are the only options)
- enabled all the "loops" needed for testing on SW1
- it could be that the UART on D0, D1 is used for stdio. In that case, do *NOT* close the loop
- flash and run the test application
### Issues/PRs references
none
20018: tests/pkg/minmea: fixing RMC timestamp r=benpicco a=jan-mo
The RMC timestamp calculation was creating issues. The timestamp will be related to the EPOCH and time zone. Test on native will fail if the time zone is not set correctly. (see #20005)
# how to test
```
TZ=GMT-1 make test
```
and
```
TZ=GMT make test
```
and
```
TZ=<any> make test
```
`timedatectl list-timezones` provides you with a List of timzones
do not fail
20022: pkg/lwip: add support for slipdev r=benpicco a=benpicco
20025: tests/drivers/at: fix device table overflow r=benpicco a=krzysztof-cabaj
### Contribution description
This PR fix device table overflow in `tests/driver/at`, which could lead to device crash.
### Testing procedure
PR was tested on two nucleo boards with 2 and 3 UARTs (nucleo-l476rg and nucleo-l496zg).
Flash `tests/driver/at` with and without this PR.
Output with this PR:
```
> main(): This is RIOT! (Version: 2022.07-devel-5083-g2b9e8-tests-drivers-at)
AT command test app
> init 5 9600
Wrong UART device number - should by in range 0-2.
>
```
Output without this PR:
```
> main(): This is RIOT! (Version: 2022.07-devel-5083-g2b9e8)
AT command test app
> init 5 9600
8001afd
*** RIOT kernel panic:
FAILED ASSERTION.
*** halted.
Context before hardfault:
r0: 0x0000000a
r1: 0x00000000
. . .
```
### Issues/PRs references
None
Co-authored-by: Marian Buschsieweke <marian.buschsieweke@posteo.net>
Co-authored-by: Jan Mohr <jan.mohr@ml-pa.com>
Co-authored-by: Benjamin Valentin <benjamin.valentin@ml-pa.com>
Co-authored-by: krzysztof-cabaj <kcabaj@gmail.com>
bors bot
added a commit
that referenced
this pull request
Oct 27, 2023
19932: tests/periph: Add test using the Peripheral Selftest Shield r=benpicco a=maribu
### Contribution description
This adds a test that makes use of the peripheral selftesting shield.
#### ToDo
- [x] Add doc
### Testing procedure
- grab an Arduino UNO compatible board that has the Arduino pin map feature
- connect it to the testing shield
- configure the testing shield
- make sure the VCC selector matches the logic level of the board (3.3V and 5V are the only options)
- enabled all the "loops" needed for testing on SW1
- it could be that the UART on D0, D1 is used for stdio. In that case, do *NOT* close the loop
- flash and run the test application
### Issues/PRs references
none
20018: tests/pkg/minmea: fixing RMC timestamp r=benpicco a=jan-mo
The RMC timestamp calculation was creating issues. The timestamp will be related to the EPOCH and time zone. Test on native will fail if the time zone is not set correctly. (see #20005)
# how to test
```
TZ=GMT-1 make test
```
and
```
TZ=GMT make test
```
and
```
TZ=<any> make test
```
`timedatectl list-timezones` provides you with a List of timzones
do not fail
Co-authored-by: Marian Buschsieweke <marian.buschsieweke@posteo.net>
Co-authored-by: Jan Mohr <jan.mohr@ml-pa.com>
bors bot
added a commit
that referenced
this pull request
Oct 27, 2023
20018: tests/pkg/minmea: fixing RMC timestamp r=benpicco a=jan-mo The RMC timestamp calculation was creating issues. The timestamp will be related to the EPOCH and time zone. Test on native will fail if the time zone is not set correctly. (see #20005) # how to test ``` TZ=GMT-1 make test ``` and ``` TZ=GMT make test ``` and ``` TZ=<any> make test ``` `timedatectl list-timezones` provides you with a List of timzones do not fail Co-authored-by: Jan Mohr <jan.mohr@ml-pa.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will extend the minmea test with additional NMEA sentences like GGA, GSA and RMC.