-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sys/cpp_new_delete: always enable the module when C++ is used #20348
Conversation
@MrKevinWeiss This might be something to backport. I think it is safe to assume that this doesn't break things, and hence, doesn't invalidate release testing. |
OK... |
Actually, since this is a fix for a specific distro I think it can land just in the 2024.01-branch and we will include it in future point releases if needed (it takes quite a while to get it in otherwise)... |
It should become relevant when riotdocker switches to Ubuntu 24.04 |
For the CI the docker image is tagged. But a user running Anyway, if it is in the |
won't that be after the next release? |
Presence of __dso_handle signal has been solved in RIOT by PR 20348. Thus removal of -nostartfiles option is no more necessary. Also bump C++ version to C++20. [1] RIOT-OS/RIOT#20348
Presence of __dso_handle signal has been solved in RIOT by PR 20348. Thus removal of -nostartfiles option is no more necessary. Also bump C++ version to C++20. [1] RIOT-OS/RIOT#20348
Presence of __dso_handle signal has been solved in RIOT by PR 20348. Thus removal of -nostartfiles option is no more necessary. Also CXXEXFLAGS setup can be done before include of RIOT Makefile.include [1] RIOT-OS/RIOT#20348
Presence of __dso_handle signal has been solved in RIOT by PR 20348. Thus removal of -nostartfiles option is no more necessary. Also CXXEXFLAGS setup can be done before include of RIOT Makefile.include [1] RIOT-OS/RIOT#20348
Presence of __dso_handle signal has been solved in RIOT by PR 20348. Thus removal of -nostartfiles option is no more necessary. Also CXXEXFLAGS setup can be done before include of RIOT Makefile.include [1] RIOT-OS/RIOT#20348 Signed-off-by: Gilles DOFFE <g.doffe@gmail.com>
Contribution description
Newer toolchains appear to expect the presence of
__dso_handle
, so always enable the module.The linker will collect unused sections anyway.
Testing procedure
sys/cpp_ctors
builds again on Ubuntu 23.10.On
master
it would produceIssues/PRs references