Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cpu/stm32/eth: fix and improve ETH defines #21072

Merged
merged 2 commits into from
Dec 11, 2024
Merged

cpu/stm32/eth: fix and improve ETH defines #21072

merged 2 commits into from
Dec 11, 2024

Conversation

krzysztof-cabaj
Copy link
Contributor

Contribution description

This PR fixes and improves some ETH defines from cpu_eth.h:

  • RX_DESC_STAT_ES (line 99) - wrong bit number - see reference manual, page 1812,
  • TX_DESC_STAT_CIC... (line 143) - some improvements from @maribu, see PR #19952.

Testing procedure

I tested this change in nucleo-f439zi and nucleo-f207zg - and after change they works.
Check once again reference manual and used bits.

Issues/PRs references

PR #19952

@github-actions github-actions bot added Platform: ARM Platform: This PR/issue effects ARM-based platforms Area: cpu Area: CPU/MCU ports labels Dec 11, 2024
maribu
maribu approved these changes Dec 11, 2024
View reviewed changes
Copy link
Member

@maribu maribu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx for spotting and fixing this :)

@maribu maribu enabled auto-merge December 11, 2024 10:42
@maribu maribu added Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors) CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Dec 11, 2024
@riot-ci
Copy link

riot-ci commented Dec 11, 2024

Murdock results

✔️ PASSED

bb982ad cpu/stm32/eth: improve defines concerning checksum

Success Failures Total Runtime
10249 0 10249 20m:10s

Artifacts

@maribu maribu added this pull request to the merge queue Dec 11, 2024
Merged via the queue into RIOT-OS:master with commit 51cd8b9 Dec 11, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maribu maribu maribu approved these changes

@aabadie aabadie Awaiting requested review from aabadie aabadie is a code owner

@vincent-d vincent-d Awaiting requested review from vincent-d vincent-d is a code owner

Assignees
No one assigned
Labels
Area: cpu Area: CPU/MCU ports CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Platform: ARM Platform: This PR/issue effects ARM-based platforms Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@krzysztof-cabaj @riot-ci @maribu