-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement NETOPT_ACK_REQ configuration option. #5297
Conversation
c17df0c
to
574c15f
Compare
This change definitely matches the intended option to set better. Did you check with all the other occurrences of |
Yes, it's a bit of a mess unfortunately. For example, the |
@aeneby I agree with your proposal. This PR won't change the driver behaviour (should be cleared up in following PRs) but introduces capabilities to differentiate between a hardware procedure on receiving frames and to set the regarding bit in the 802.15.4 header on sending frames. |
Allows setting the acknowledgement request bit of 802.15.14 headers via netdev.
Thanks @PeterKietzmann - done, rebased and squashed. |
ACK and go |
added option to kw2xrf -> #5469 |
This fixes #5287 - currently the option
NETOPT_AUTOACK
is incorrectly being used to set the AR (acknowledge request) bit of the 802.15.4 MAC header. This PR introduces a new option for doing this instead,NETOPT_ACK_REQ
, leaving it up to the driver to set AUTOACK when requested.