Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement NETOPT_ACK_REQ configuration option. #5297

Merged
merged 1 commit into from
May 31, 2016

Conversation

aeneby
Copy link
Member

@aeneby aeneby commented Apr 12, 2016

This fixes #5287 - currently the option NETOPT_AUTOACK is incorrectly being used to set the AR (acknowledge request) bit of the 802.15.4 MAC header. This PR introduces a new option for doing this instead, NETOPT_ACK_REQ, leaving it up to the driver to set AUTOACK when requested.

@OlegHahm OlegHahm added this to the Release 2016.07 milestone Apr 12, 2016
@OlegHahm OlegHahm added Type: new feature The issue requests / The PR implemements a new feature for RIOT GNRC labels Apr 12, 2016
@miri64 miri64 assigned haukepetersen and unassigned miri64 Apr 13, 2016
@aeneby aeneby force-pushed the netopt_ack_req branch 2 times, most recently from c17df0c to 574c15f Compare April 26, 2016 03:38
@miri64 miri64 assigned miri64 and unassigned haukepetersen Apr 26, 2016
@thomaseichinger
Copy link
Member

This change definitely matches the intended option to set better. Did you check with all the other occurrences of NETDEV_AUTOACK they actually mean 'autoack'?

@aeneby
Copy link
Member Author

aeneby commented Apr 26, 2016

Yes, it's a bit of a mess unfortunately. For example, the kw2xrf and the at86rf2xx drivers seem to do a combination of enabling both AUTOACK and the AR bit when the NETOPT_AUTOACK option is set. But at least this patch constrains the problem to the drivers themselves, and introduces a new option so that the problem can be fixed - we can open new PRs for the drivers themselves afterwards.

@PeterKietzmann PeterKietzmann added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label May 31, 2016
@PeterKietzmann
Copy link
Member

@aeneby I agree with your proposal. This PR won't change the driver behaviour (should be cleared up in following PRs) but introduces capabilities to differentiate between a hardware procedure on receiving frames and to set the regarding bit in the 802.15.4 header on sending frames.

@PeterKietzmann
Copy link
Member

@aeneby you need to add an entry for the new option here. Once done, we're not far from merging this PR

@miri64 miri64 assigned PeterKietzmann and unassigned miri64 May 31, 2016
Allows setting the acknowledgement request bit of 802.15.14
headers via netdev.
@aeneby
Copy link
Member Author

aeneby commented May 31, 2016

Thanks @PeterKietzmann - done, rebased and squashed.

@PeterKietzmann
Copy link
Member

ACK and go

@PeterKietzmann PeterKietzmann merged commit e12830c into RIOT-OS:master May 31, 2016
@aeneby aeneby deleted the netopt_ack_req branch May 31, 2016 23:18
@jfischer-no
Copy link
Contributor

added option to kw2xrf -> #5469

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: network Area: Networking CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Type: new feature The issue requests / The PR implemements a new feature for RIOT
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feature: implement NETOPT_ACK_REQ
7 participants