shell: Enable setting acknowledgement request flag from shell #5523
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miri64
added
the
Type: enhancement
|
ACK and go when Murdock is happy. |
miri64
added
the
CI: ready for build
|
pr and commit title are not optimal. |
|
True, @aeneby please prefix your PR and commit titles with the module(s) you change |
aeneby
changed the title
|
Fixed. |
|
re-ACK |
|
thx! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds functionality to the shell for setting/unsetting the acknowledgement request bit of sent packets, via the NETOPT_ACK_REQ option introduced in PR #5297.