Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

net/gcoap: increase stack size by sizeof(coap_pkt_t) [BACKPORT] #9000

Merged
merged 1 commit into from
Apr 23, 2018
Merged

net/gcoap: increase stack size by sizeof(coap_pkt_t) [BACKPORT] #9000

merged 1 commit into from
Apr 23, 2018

Conversation

kaspar030
Copy link
Contributor

Contribution description

(Backport of #8998.)

Apparently the latest nanocoap rework had side effects on gcoap's stack usage, and not of the good kind.

This PR adds sizeof(coap_pkt_t) to the gcoap stacksize. Meant as quickfix for the release, better solution is on its way.
Issues/PRs references

Fixes #8981.

@kaspar030 kaspar030 added Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors) CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Process: release backport Integration Process: The PR is a release backport of a change previously provided to master labels Apr 23, 2018
@kaspar030 kaspar030 requested review from miri64 and kb2ma April 23, 2018 07:54
@kaspar030 kaspar030 changed the title net/gcoap: increase stack size by sizeof(coap_pkt_t) net/gcoap: increase stack size by sizeof(coap_pkt_t) [BACKPORT] Apr 23, 2018
cgundogan
cgundogan approved these changes Apr 23, 2018
View reviewed changes
Copy link
Member

@cgundogan cgundogan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@cgundogan cgundogan merged commit 817551a into RIOT-OS:2018.04-branch Apr 23, 2018
@kaspar030 kaspar030 deleted the backport_gcoap_fix branch April 23, 2018 08:06
@kb2ma kb2ma mentioned this pull request May 12, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cgundogan cgundogan cgundogan approved these changes

@miri64 miri64 Awaiting requested review from miri64

@kb2ma kb2ma Awaiting requested review from kb2ma

Assignees
No one assigned
Labels
CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Process: release backport Integration Process: The PR is a release backport of a change previously provided to master Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kaspar030 @cgundogan