-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
09-coap: add CoAP release specs #77
Conversation
Making good progress; one more task to go. I did just find a bug in nanocoap that probably should be fixed for the release, so I'll create a PR for that before continuing with the test spec. |
Good to have dedicated tests using A remark that shows a flaw in my previous naming, maybe my task 09 should be named 99 as I wanted it to be an optional bonus task. This way your task would be a more important task directly after the others. I can rename it. |
thanks @kb2ma !! |
It went away :) |
Added Observe task, renamed to 09-coap. Squashed and ready for review. The content should be usable by others. Also, from my perspective gcoap and nanocoap work fine in 2018.10-branch with the fix in RIOT #10298. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These specifications are providing good tests of the basic CoAP features available in RIOT. I tried all of them with success by following the description given. Maybe adding a note on how to setup the tap (like it's done gnrc_networking example) could also help.
I found minor typos in the documentation and I also think the lines could be split to 80 characters width.
It would be great to have these CoAP release specs also tested for the next release (2019.01).
09-coap/coap.md
Outdated
============================== | ||
### Description | ||
|
||
gcoap sends a CON GET requst to an aiocoap server. The test runner delays startup of aiocoap to trigger gcoap to resend the message. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s/requst/request/ + 2 spaces between runner
and delays
09-coap/coap.md
Outdated
================= | ||
### Description | ||
|
||
aiocoap slices a payload into a sequence of Block1 encoded POSTs to nanocoap. nanocoap computes and returns the SHA-256 message digest on the payload. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s/on the payload/of the payload/ ?
Thanks for the review. I added a couple of fixups to address your concerns. Rather than fully explain the tap setup, I included scripts to set up and teardown, and referenced them in the instructions. Let me know if that is good enough. Also FWIW, RIOT #10671 added a feature to tests/nanocoap_cli to specify a number of requests to ignore. This will make test |
Pushed the wrong button. :-) |
And of course I'm happy to run these tests for the release. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Squashed, looks good to me. |
Thanks, let's merge! |
Contribution description
Basic coverage for CoAP messaging as described in #73. The goal for this PR is to include non-confirmable and confirmable messaging, block extension, and observe extension. Includes some tests for both gcoap and nanocoap. Includes test of RIOT Resource Directory client implementation (CORD).
Initial commit probably premature, but I wanted to get the message out that I'm working on it for the 2018.10 release. :-)
Issues/PRs references
Resolves #73