Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

99-compile-and-test-one-board: rename to be the last task #78

Merged
merged 1 commit into from
Oct 29, 2018

Conversation

cladmi
Copy link
Contributor

@cladmi cladmi commented Oct 29, 2018

Rename 09-compile-and-test-one-board to 99- to be sure it is the last task.
The goal is to be an optional step that is a bonus to the normal ones.

This will allow adding more easily new mandatory tasks with contiguous numbers.

Related issues

I noticed the issue in #77 as it was being named 10- so after this optional task.

Rename 09-compile-and-test-one-board to 99- to be sure it is the last task.
The goal is to be an optional step that is a bonus to the normal ones.

This will allow adding more easily new mandatory tasks with contiguous numbers.
@cladmi cladmi requested review from jia200x and kb2ma October 29, 2018 15:05
@jia200x
Copy link
Member

jia200x commented Oct 29, 2018

Makes sense to me.

Copy link
Member

@jia200x jia200x left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's only a name change. Commit name looks perfect. ACK

@jia200x jia200x merged commit 4ee64ec into RIOT-OS:master Oct 29, 2018
@cladmi
Copy link
Contributor Author

cladmi commented Oct 29, 2018

Thanks for the review.

@cladmi cladmi deleted the pr/compile_task/rename branch November 8, 2018 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants