-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
C2Rust: Use upstream as patches are not required any more #173
Conversation
7647671
to
a735fd6
Compare
Also, given that it's now generic-C2Rust and not RIOT-vendored, it might be a good time to go all the way to making it a Debian package; it would still be buildable through the Dockerfile, but also in a standalone way. |
The 2022.01 release is through, and I'd like to update this now -- one more step toward doing things the nice and easy way. Along with the mere version and upstream source change, I've moved a few components over into the Debian package creation. This makes it easier to build a suitable c2rust also for other containers that might not be based on the precise Ubuntu version riotdocker is currently using, and the README reflects that. |
16da86c
to
503b060
Compare
The updates contained signs of brief confusion (I thought there couldn't be |
Tested by building riotdocker on it, and building the rust-gcoap example for native, microbit-v2 and hifive1b. (Not that I'd expect any change -- this is practically just switching to upstream which merged my PRs, and changing things about how c2rust is built). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK.
(This is simpler now, less forks involved, but the c2rust build story is still something that I wouldn't read to my kids ;) )
bors merge |
Thanks, submission in process.
Fortunately, upstream has started porting it away from using compiler internals to using regularly released crates (albeit still at an early stage). Once that's done, it'll be a less-than-5-minutes bed time story ending with "and they used |
nice, looking forward to that! |
Build succeeded: |
C2Rust has accepted most of the patches in the current for-riot; what's left needs riot-sys fixes anyway on the long run.
Issues/PRs references
A sibling PR on RIOT docs is RIOT-OS/RIOT#17536
Status
This is on hold as a draft because it still depends on two things:
cargo update
, but that shouldn't be necessary for users to do to run the demos), so this will need to wait until the current release is through-- and then maybe some time for good measure as to not cause any trouble for people on branches that haven't received the no-llvm-asm riot-wrappers update from RIOT yet.
[edit: Turned into a checklist, as first item is done]