doc: C2Rust does not need patching any more. #17536
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
bors bot
added a commit
to RIOT-OS/riotdocker
that referenced
this pull request
Mar 9, 2022
173: C2Rust: Use upstream as patches are not required any more r=kaspar030 a=chrysn C2Rust has accepted most of the patches in the current for-riot; what's left needs riot-sys fixes anyway on the long run. ### Issues/PRs references A sibling PR on RIOT docs is RIOT-OS/RIOT#17536 ### Status This is on hold as a draft because it still depends on two things: * [x] The no-llvm-asm branch of riot-wrappers to be merged, released and the Cargo.lock files here to be updated to use it, and * [x] The unpatched C2Rust won't work for older Rust-on-RIOT versions (fixable with a `cargo update`, but that shouldn't be necessary for users to do to run the demos), so this will need to wait until the current release is through -- and then maybe some time for good measure as to not cause any trouble for people on branches that haven't received the no-llvm-asm riot-wrappers update from RIOT yet. [edit: Turned into a checklist, as first item is done] Co-authored-by: chrysn <chrysn@fsfe.org>
chrysn
force-pushed
the
use-upstream-c2rust
branch
from
2283b02 to
b5bcedd
Compare
chrysn
force-pushed
the
use-upstream-c2rust
branch
from
b5bcedd to
01573a1
Compare
|
With RIOT-OS/riotdocker#173 merged this is now ready for prime time too. Tests for this are thus already performed in riotdocker (and additionally on every single build once the latest riotbuild images are rolled out). Rebased to resolve conflicts and a grammar error. |
chrysn
added
CI: ready for build
benpicco
added
the
CI: skip compile test
benpicco
reviewed
Mar 9, 2022
benpicco
approved these changes
Mar 9, 2022
|
Just "master" is insufficient; as they update their branch, the required nightly version may change. Last time I checked (which was admittedly some time before filing this PR), there was no usable tag on the branch (I just changed this when they merged all my relevant pending PRs). Recent developments indicate that this will not happen until the point where they switch from nightly to stable, but that's all not fully clear yet. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution description
C2Rust has accepted most of the patches in the current for-riot; what's left needs riot-sys fixes anyway on the long run.
Testing procedure
For full testing:
Issues/PRs references
A sibling PR on riotdocker is RIOT-OS/riotdocker#173.
Status
This is on hold as a draft because it still depends on two things:
[edit: Finish incomplete sentence, cross-link to sibling PR; turned into bulled list after first blocker is resolved].