Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

esp32: update for toolchain version v2 #97

Merged
merged 1 commit into from
Jan 16, 2020

Conversation

gschorcht
Copy link
Contributor

@gschorcht gschorcht commented Jan 16, 2020

Description

This PR changes the reference to another commit of the precompiled ESP32 toolchain repository to update the toolchain to a version that is required to fix issue RIOT-OS/RIOT#13133.

Test

Compilation of all examples/tests in current RIOT master should succeed.

Dependencies

Requires PR RIOT-OS/RIOT#13141

Copy link
Contributor

@kaspar030 kaspar030 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK.

@kaspar030 kaspar030 merged commit 13929cd into RIOT-OS:master Jan 16, 2020
@kaspar030
Copy link
Contributor

rollout will have to wait until after release testing, though...

@gschorcht
Copy link
Contributor Author

Wow, very fast. Thanks.

So we have also to merge and backport RIOT-OS/RIOT#13141. Otherwise, a user who is generating docker image from the Dockerfile would run into compilation errors.

rollout will have to wait until after release testing, though...

The current RIOT master should work with the updated toolchain too.

@kaspar030
Copy link
Contributor

The current RIOT master should work with the updated toolchain too.

Yeah, it's just that during these weeks, I try to change as little as possible in the CI infrastructure. Losing half a day on a revert-and-redeploy-and-retest cycle is painful for the people trying to get backports and fixes CIed. (Not that I think this PR would cause that.)

@gschorcht
Copy link
Contributor Author

@kaspar030 The release is out. We could try to roll out that change now.

The fix in PR RIOT-OS/RIOT#13141 was backported to the release with PR RIOT-OS/RIOT#13144. So there should be no risk to roll it out. Once it is rolled out, we can revert RIOT-OS/RIOT#13140.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants