Add CMake HIP language support #740
Draft
+119
−43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add USE_HIPCXX option to build using CMake's support for the HIP language. This option requires CMake 3.21.3 or newer. The rocsolver clients shouldn't need to be built as HIP, but they require rocblas_is_complex, which is only provided by the rocblas headers when compiling as HIP. In the future, this could be corrected. Note that set_source_files_properties only affects the targets declared in the same CMake file as the call to set the properties. As such, it is difficult to use together with target_sources. All uses of latter have therefore been removed. The project declaration in the clients directory has also been removed so that PROJECT_SOURCE_DIR can always be used to refer to the root directory.
cgmb
added
noOptimizations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
USE_HIPCXXoption to build using CMake's support for the HIP language. This option requires CMake 3.21.3 or newer.The rocsolver clients shouldn't need to be built as HIP, but they require
rocblas_is_complex<T>, which is only provided by the rocblas headers when compiling as HIP. In the future, this could be corrected.Note that
set_source_files_propertiesonly affects the targets declared in the same CMake file as the call to set the properties. As such, it is difficult to use together withtarget_sources. All uses of latter have therefore been removed. The project declaration in the clients directory has also been removed so thatPROJECT_SOURCE_DIRcan always be used to refer to the root directory.