Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add CMake HIP language support #740

Draft
wants to merge 2 commits into
base: develop
Choose a base branch
from
Draft

Add CMake HIP language support #740

wants to merge 2 commits into from
+119 −43

Commits on Jun 13, 2024

  1. Add CMake HIP language support 

    Add USE_HIPCXX option to build using CMake's support for the
HIP language. This option requires CMake 3.21.3 or newer.

The rocsolver clients shouldn't need to be built as HIP, but they
require rocblas_is_complex, which is only provided by the rocblas
headers when compiling as HIP. In the future, this could be
corrected.

Note that set_source_files_properties only affects the targets declared
in the same CMake file as the call to set the properties. As such, it
is difficult to use together with target_sources. All uses of latter
have therefore been removed. The project declaration in the clients
directory has also been removed so that PROJECT_SOURCE_DIR can always
be used to refer to the root directory.
    @cgmb
    cgmb committed Jun 13, 2024
    Configuration menu
    Copy the full SHA
    b3c5c2b View commit details
    Browse the repository at this point in the history

  2. Link hip::device in the clients to enable rocblas_is_complex

    @cgmb
    cgmb committed Jun 13, 2024
    Configuration menu
    Copy the full SHA
    957b4fb View commit details
    Browse the repository at this point in the history