Reduce number of interfaces scanned for UPnP gateways #4904
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The dialogs were unstylish and intrusive, constantly stealing focus for no reason. While the glass pane does not mention the specific interfaces being scanned, they will be located in the logs in case it ever matters.
kwvanderlinde
force-pushed
the
bugfix/4902-upnp-interfaces
branch
from
49ab85b
to
0ccc673
Compare
kwvanderlinde
added
bug
performance
kwvanderlinde
changed the title
This was referenced Sep 13, 2024
Closed
github-merge-queue bot
pushed a commit
that referenced
this pull request
Sep 19, 2024
…es--reapply-to-develop Reduce number of interfaces scanned for UPnP gateways (reapply #4904)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Identify the Bug or Feature request
Addresses #4902
Description of the Change
This changes the UPnP discovery logic to avoid network interfaces with no associated IP address. The goal is to reduce the number of devices that the UPnP scan has to wait for.
An additional change is to remove the dialogs displaying the specific interfaces in favour of a static glass pane that indicates UPnP setup is ongoing. The interfaces will still be logged, so they can be found for future reference if needed.
On my main Windows machines, this reduced the number of interfaces from ~12 to 2, with both remaining interfaces being legitimate possibilities for UPnP.
Possible Drawbacks
None
Documentation Notes
N/A
Release Notes
This change is