Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rel 1 15 dev merge #4907

Closed
wants to merge 22 commits into from
Closed

Conversation

cwisniew
Copy link
Member

@cwisniew cwisniew commented Sep 13, 2024

Identify the Bug or Feature request

Merge 1.15 branch back into develop


This change is Reviewable

kwvanderlinde and others added 22 commits May 26, 2024 00:31
It's meant to be run off-thread, so use `.execute()` instead of `.run()`.
…information

Do not run the InfoTextSwingWorker on the EDT thread
Swap gridHorizontalHex.svg and gridVerticalHex.svg as they were backwards
…ect-hex-grid-icons

Swap hex grid icons in Rod's theme
This reverts commit cf937da, reversing
changes made to 4ac15e4.
Fix themes, default property sets not being installed correctly
hasLightSource & Campaign Panel drag-drop bug fix
The dialogs were unstylish and intrusive, constantly stealing focus for no reason. While the glass pane does not mention
the specific interfaces being scanned, they will be located in the logs in case it ever matters.
…nterfaces

Reduce number of interfaces scanned for UPnP gateways
@cwisniew cwisniew added the ignore-for-release-note Wont be auto added to the release note label Sep 13, 2024
@thelsing
Copy link
Collaborator

Commmit bd6f2ef hast so many changes that I can't tell if they are correct as I wasn't really involved in 1.15. I'm not sure if changes that @kwvanderlinde did are undone with it.

@cwisniew
Copy link
Member Author

Commmit bd6f2ef hast so many changes that I can't tell if they are correct as I wasn't really involved in 1.15. I'm not sure if changes that @kwvanderlinde did are undone with it.

Yeah I just had a look, git has made an absolute mess of the merge. Sadly it looks like we are going to have to go through all the changes in 1.15 and re do them (ugh)

@cwisniew cwisniew closed this Sep 13, 2024
@kwvanderlinde
Copy link
Collaborator

kwvanderlinde commented Sep 13, 2024

That'll be due to the accidental merge of develop in to release-1.15 (cf937da) and the subsequent revert. We should undo that to avoid any future headaches. I.e., reset release-1.15 to 4ac15e4, then redo the few PRs that went into 1.15 since then:

I'd be happy to do it if you'd like to avoid the tedium.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ignore-for-release-note Wont be auto added to the release note
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants