Do not disclose GM maps to players in status UI #4982
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Although having more than one GM connected is rare, we should still probably show the information to GMs. |
|
Fair enough. I didn't think it was too important for GMs to keep track of each other, but I will add it in. |
Its not so much keeping track of which map they were on, but the original request that generated this functionality was about knowing if maps had loaded for other users. So I can see people wanting that feature back |
This hides the name of the zone in the Connections window and the status bar it won't be revealed to players.
kwvanderlinde
force-pushed
the
bugfix/4595-connections-window-disclosing-gm-maps
branch
from
2aa68ae
to
7f96281
Compare
|
Updated so GMs can once again see each other's zone. |
cwisniew
approved these changes
Oct 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Identify the Bug or Feature request
Fixes #4595
Description of the Change
For player clients, this hides the name of the GM's zone in the Connections window and status bar. Players can still see each other's zones, and GMs can still see everyone's zone.
Possible Drawbacks
None
Documentation Notes
In the Connections window, players cannot see the map any GM is on. Same for the status bar indicator.
Release Notes
This change is