#4961 #5008 #4954 Bug Fixes #5007
Open
+23
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RPTools#4954 User Overlays break with new statsheets
|
This overlay may be used in other functionality in the future so the name can't be hard coded like this |
Reverted usage of AppConstants.
|
It needs more work, I'm still missing something edit |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes:
#4961 NPE on mouse off (needs testing, I can't validate)
#5008 Stat sheet not in front
#4954 User Overlays break with new statsheets
Description of the Change
#4961 adds an empty var
ifcheck. Needs testing as I don't have the OS to validate this change on.#5008 changed variable used from min to max
#4954 loads a blank overlay on build of a campaign
Possible Drawbacks
For #4954 I do not call to close the overlay; an empty overlay is supposed to be removed anyway.
This change is