Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable mypy checks for all error codes #8243

Closed
2 tasks
wochinge opened this issue Mar 18, 2021 · 7 comments
Closed
2 tasks

Enable mypy checks for all error codes #8243

wochinge opened this issue Mar 18, 2021 · 7 comments
Assignees
Labels
area:rasa-oss 🎡 Anything related to the open source Rasa framework type:maintenance 🔧 Improvements to tooling, testing, deployments, infrastructure, code style.

Comments

@wochinge
Copy link
Contributor

Maxime recently enabled mypy support for the first couple of issues. In our current setup we ignore certain typing issues as there are currently too many to tackle them all at once.

We should instead tackle them step by step. Parent issue.
This is the parent issue to make sure we tackle of the categories.

Definition of Done:

  • enable mypy checks for for all error codes
  • issues are fixed
@wochinge wochinge added type:maintenance 🔧 Improvements to tooling, testing, deployments, infrastructure, code style. area:rasa-oss 🎡 Anything related to the open source Rasa framework labels Mar 18, 2021
@TyDunn
Copy link
Contributor

TyDunn commented Jul 2, 2021

@wochinge are there more error codes besides the ones referenced in this issue?

@wochinge
Copy link
Contributor Author

wochinge commented Jul 5, 2021

Yep, a whole bunch:

disable_error_code = arg-type, assignment, var-annotated, return-value, union-attr,
    override, operator, attr-defined, index, misc, return, func-returns-value

@wochinge
Copy link
Contributor Author

wochinge commented Jul 5, 2021

@wochinge
Copy link
Contributor Author

wochinge commented Jul 5, 2021

Starting with the index one and func-returns-value

@wochinge wochinge mentioned this issue Jul 6, 2021
4 tasks
@twerkmeister twerkmeister mentioned this issue Jul 6, 2021
2 tasks
@m-vdb
Copy link
Collaborator

m-vdb commented Jul 6, 2021

@wochinge can we have the list of different errors and who's handling in the description of the issue instead of a comment below? I think it's easier for collaboration 😄

@m-vdb
Copy link
Collaborator

m-vdb commented Jul 6, 2021

Also another thought @wochinge , it's possible that some of the remaining errors are not easy to fix and require some revamping (I remember hitting some issues with data structures). We might want to flag them (disable them locally and open follow-up ticket) and do them after the revamp. Just a thought 🤔

@wochinge
Copy link
Contributor Author

wochinge commented Jul 12, 2021

Created issues for each remaining error code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:rasa-oss 🎡 Anything related to the open source Rasa framework type:maintenance 🔧 Improvements to tooling, testing, deployments, infrastructure, code style.
Projects
None yet
Development

No branches or pull requests

3 participants