-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable mypy
checks for all error codes
#8243
Comments
@wochinge are there more error codes besides the ones referenced in this issue? |
Yep, a whole bunch:
|
|
Starting with the |
@wochinge can we have the list of different errors and who's handling in the description of the issue instead of a comment below? I think it's easier for collaboration 😄 |
Also another thought @wochinge , it's possible that some of the remaining errors are not easy to fix and require some revamping (I remember hitting some issues with data structures). We might want to flag them (disable them locally and open follow-up ticket) and do them after the revamp. Just a thought 🤔 |
Created issues for each remaining error code. |
Maxime recently enabled
mypy
support for the first couple of issues. In our current setup we ignore certain typing issues as there are currently too many to tackle them all at once.We should instead tackle them step by step. Parent issue.
This is the parent issue to make sure we tackle of the categories.
Definition of Done:
mypy
checks for for all error codesThe text was updated successfully, but these errors were encountered: