-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch to mypy part1 #6511
Switch to mypy part1 #6511
Conversation
3e4c55d
to
a797f7b
Compare
@wochinge after merging master into this branch, I have to fix more issues. I have a question about |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All done besides from a small snippet in rasa.server
.
Nice work! Cool to see that mypy also helps us detecting and removing technical debt! 🥇
@wochinge thanks for your review! This PR was not really ready for review, but the "part0" is. Would you mind taking a look? |
🙈 will do |
Co-authored-by: Tobias Wochinger <t.wochinger@rasa.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice to get this in! 🚀 Great work! Do we have follow up issues for the enable squad for this?
@wochinge no we don't as I don't know how the squad wants to split the work on this yet. Maybe let's have a single placeholder issue to discuss this, and create other issues when we're ready to tackle it? |
Do you have some up do date statistics how often each error type is occuring? How about putting this in the squad channel? In my opinion we should have ready to go issue for refinement and then sprint planning. |
let me compile this and share it |
Proposed changes:
Fix the following typing issues:
dict-item
list-item
call-arg
Leftovers to merge this PR
rasa.core.actions.action
to resolve (needs input from reviewer)rasa.core.actions.two_stage_fallback
to resolve (needs input from reviewer)rasa.core.test
to resolve (ready to implement)rasa.shared.nlu.training_data.lookup_tables_parser
to resolve (ready to implement)tests
to resolve (needs input from reviewer)rasa.server
module)main
in the branch and fix merge conflictsUpdaterasa.model.Fingerprint
typing (possibly in another task)Status (please check what you already did):
black
(please check Readme for instructions)