Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix mypy index issues #9043

Merged
merged 15 commits into from
Jul 6, 2021
Merged

fix mypy index issues #9043

merged 15 commits into from
Jul 6, 2021

Conversation

wochinge
Copy link
Contributor

@wochinge wochinge commented Jul 6, 2021 •
edited
Loading

Proposed changes:

Status (please check what you already did):

  • added some tests for the functionality
  • updated the documentation
  • updated the changelog (please check changelog for instructions)
  • reformat files using black (please check Readme for instructions)

@wochinge wochinge requested a review from a team as a code owner July 6, 2021 07:19
@wochinge wochinge requested review from a team, ka-bu and ancalita and removed request for a team July 6, 2021 07:19
@wochinge wochinge mentioned this pull request Jul 6, 2021
Closed
2 tasks
ka-bu
ka-bu suggested changes Jul 6, 2021
View reviewed changes
Copy link
Contributor

@ka-bu ka-bu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks for adding those TypedDicts and comments! There's just one tiny thing that would save me some confusion in the future, I think (sorry) (see comment)

rasa/core/policies/rule_policy.py Outdated Show resolved Hide resolved
@wochinge wochinge requested a review from ka-bu July 6, 2021 13:51
ancalita
ancalita approved these changes Jul 6, 2021
View reviewed changes
Copy link
Member

@ancalita ancalita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@wochinge wochinge merged commit 761cfc3 into main Jul 6, 2021
@wochinge wochinge deleted the misc/mypy-index branch July 6, 2021 15:12
@wochinge wochinge mentioned this pull request Jul 6, 2021
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ancalita ancalita ancalita approved these changes

@ka-bu ka-bu ka-bu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wochinge @ka-bu @ancalita