-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ATO-1151] Parentheses in button title overwrite button payload in rasa shell #12534
Merged
Urkem
merged 10 commits into
3.5.x
from
ATO-1151-parentheses-in-button-title-overwrite-button-payload-in-rasa-shell
Jun 22, 2023
Merged
[ATO-1151] Parentheses in button title overwrite button payload in rasa shell #12534
Urkem
merged 10 commits into
3.5.x
from
ATO-1151-parentheses-in-button-title-overwrite-button-payload-in-rasa-shell
Jun 22, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ancalita
reviewed
Jun 21, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left two suggestions for improving the changelog, and asked a question for my understanding 😄
ancalita
approved these changes
Jun 21, 2023
ancalita
reviewed
Jun 22, 2023
🚀 A preview of the docs have been deployed at the following URL: https://12534--rasahq-docs-rasa-v2.netlify.app/docs/rasa |
Urkem
deleted the
ATO-1151-parentheses-in-button-title-overwrite-button-payload-in-rasa-shell
branch
June 22, 2023 15:29
Merged
4 tasks
souvikg10
pushed a commit
that referenced
this pull request
Jun 26, 2023
…sa shell (#12534) * fix button question * fix lint * add changelog * edit changelog * fix test * skip flaky windows tests * add skip * skip additional * add another test to skip * skip lm featuizer on windows
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes:
Status (please check what you already did):
black
(please check Readme for instructions)