Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ATO-1151] Parentheses in button title overwrite button payload in rasa shell #12534

Conversation

Urkem
Copy link
Contributor

@Urkem Urkem commented Jun 20, 2023

Proposed changes:

Status (please check what you already did):

  • added some tests for the functionality
  • updated the documentation
  • updated the changelog (please check changelog for instructions)
  • reformat files using black (please check Readme for instructions)

@Urkem Urkem requested a review from a team as a code owner June 20, 2023 12:21
Copy link
Member

@ancalita ancalita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left two suggestions for improving the changelog, and asked a question for my understanding 😄

changelog/12534.bugfix.md Outdated Show resolved Hide resolved
changelog/12534.bugfix.md Outdated Show resolved Hide resolved
tests/cli/test_utils.py Show resolved Hide resolved
@github-actions
Copy link
Contributor

🚀 A preview of the docs have been deployed at the following URL: https://12534--rasahq-docs-rasa-v2.netlify.app/docs/rasa

@Urkem Urkem merged commit faa7337 into 3.5.x Jun 22, 2023
@Urkem Urkem deleted the ATO-1151-parentheses-in-button-title-overwrite-button-payload-in-rasa-shell branch June 22, 2023 15:29
souvikg10 pushed a commit that referenced this pull request Jun 26, 2023
…sa shell (#12534)

* fix button question

* fix lint

* add changelog

* edit changelog

* fix test

* skip flaky windows tests

* add skip

* skip additional

* add another test to skip

* skip lm featuizer on windows
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants