Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ATO-1151] Port of parentheses in button title overwrite button payload in rasa shell #12568

Merged
merged 6 commits into from
Jul 3, 2023
Merged

[ATO-1151] Port of parentheses in button title overwrite button payload in rasa shell #12568

merged 6 commits into from
Jul 3, 2023

Conversation

Urkem
Copy link
Contributor

@Urkem Urkem commented Jun 27, 2023

Proposed changes:

  • Port of PR

Status (please check what you already did):

  • added some tests for the functionality
  • updated the documentation
  • updated the changelog (please check changelog for instructions)
  • reformat files using black (please check Readme for instructions)

@Urkem Urkem requested a review from a team as a code owner June 27, 2023 13:03
@Urkem Urkem requested review from radovanZRasa and removed request for a team June 27, 2023 13:03
@github-actions
Copy link
Contributor

🚀 A preview of the docs have been deployed at the following URL: https://12568--rasahq-docs-rasa-v2.netlify.app/docs/rasa

vcidst
vcidst approved these changes Jun 28, 2023
View reviewed changes
Copy link
Contributor

@vcidst vcidst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@Urkem Urkem merged commit 280b66d into 3.4.x Jul 3, 2023
@Urkem Urkem deleted the ATO-1151-port-3.4.x branch July 3, 2023 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vcidst vcidst vcidst approved these changes

@radovanZRasa radovanZRasa Awaiting requested review from radovanZRasa radovanZRasa is a code owner automatically assigned from RasaHQ/atom-squad

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Urkem @vcidst