[ATO-1151] Port of parentheses in button title overwrite button payload in rasa shell

changelog/12568.bugfix.md

@@ -0,0 +1,2 @@
+Rich responses containing buttons with parentheses characters are now correctly parsed.
+Previously any characters found between the first identified pair of `()` in response button took precedence.

rasa/cli/utils.py

@@ -195,7 +195,7 @@ async def payload_from_button_question(button_question: "Question") -> Text:
     response = await button_question.ask_async()
     if response != FREE_TEXT_INPUT_PROMPT:
         # Extract intent slash command if it's a button
-        response = response[response.find("(") + 1 : response.find(")")]
+        response = response[response.rfind("(") + 1 : response.rfind(")")]
     return response
 
 

tests/cli/test_utils.py

@@ -9,6 +9,7 @@
 
 import rasa.cli.utils
 from tests.cli.conftest import RASA_EXE
+from tests.conftest import AsyncMock
 
 
 @contextlib.contextmanager
@@ -97,3 +98,18 @@ def test_validate_with_invalid_directory_if_default_is_valid(tmp_path: pathlib.P
         ) == str(tmp_path)
     assert len(record) == 1
     assert "does not seem to exist" in record[0].message.args[0]
+
+
+@pytest.mark.parametrize(
+    "text_input, button",
+    [
+        ("hi this is test text\n", "hi this is test text"),
+        ("hi this is test text (/button_one)", "/button_one"),
+        ("hi this is test text (and something) (/button_one)", "/button_one"),
+    ],
+)
+async def test_payload_from_button_question(text_input: str, button: str) -> None:
+    question = AsyncMock()
+    question.ask_async.return_value = text_input
+    result = await rasa.cli.utils.payload_from_button_question(question)
+    assert result == button