Deployment probe fixes (knative#13885)

* probe fixes * fixes * fix threshold * cleanup
ReToCode · Apr 27, 2023 · dde65c4 · dde65c4
1 parent 0a03e39
commit dde65c4
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 4 deletions.
diff --git a/cmd/domain-mapping-webhook/main.go b/cmd/domain-mapping-webhook/main.go
@@ -98,6 +98,7 @@ func main() {
 		SecretName:  "domainmapping-webhook-certs",
 	})
 
+	ctx = sharedmain.WithHealthProbesDisabled(ctx)
 	sharedmain.WebhookMainWithContext(ctx, "domainmapping-webhook",
 		certificates.NewController,
 		newDefaultingAdmissionController,

diff --git a/cmd/webhook/main.go b/cmd/webhook/main.go
@@ -163,6 +163,7 @@ func main() {
 		SecretName:  "webhook-certs",
 	})
 
+	ctx = sharedmain.WithHealthProbesDisabled(ctx)
 	sharedmain.WebhookMainWithContext(ctx, "webhook",
 		certificates.NewController,
 		newDefaultingAdmissionController,

diff --git a/config/core/deployments/controller.yaml b/config/core/deployments/controller.yaml
@@ -95,14 +95,14 @@ spec:
             port: probes
             scheme: HTTP
           periodSeconds: 5
-          failureThreshold: 5
+          failureThreshold: 6
         readinessProbe:
           httpGet:
             path: /readiness
             port: probes
             scheme: HTTP
           periodSeconds: 5
-          failureThreshold: 5
+          failureThreshold: 3
 
         ports:
         - name: metrics

diff --git a/config/core/deployments/domainmapping-controller.yaml b/config/core/deployments/domainmapping-controller.yaml
@@ -91,14 +91,14 @@ spec:
             port: probes
             scheme: HTTP
           periodSeconds: 5
-          failureThreshold: 5
+          failureThreshold: 6
         readinessProbe:
           httpGet:
             path: /readiness
             port: probes
             scheme: HTTP
           periodSeconds: 5
-          failureThreshold: 5
+          failureThreshold: 3
 
         ports:
         - name: metrics