Deployment probe fixes #13885
Deployment probe fixes #13885
Conversation
skonto
commented
Apr 14, 2023
•
skonto
commented
- In Add missing deployment probes #13563 we added defaults probes but some need to be adjusted to avoid bugs like LivenessProbe and ReadinessProbe should not be the same #9077.
- In Add health checks pkg#2671 healthchecks were added to sharedmain that are on by default. For certain deployments like webhooks these need to be disabled because we specify our own healthchecks on a different port and with different settings.
knative-prow
bot
added
size/S
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #13885 +/- ##
=======================================
Coverage 86.23% 86.23%
=======================================
Files 199 199
Lines 14706 14749 +43
=======================================
+ Hits 12681 12719 +38
- Misses 1725 1729 +4
- Partials 300 301 +1 see 4 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
cmd/domain-mapping-webhook/main.go
Outdated
| @@ -98,7 +98,7 @@ func main() { | |||
| SecretName: "domainmapping-webhook-certs", | |||
| }) | |||
|
|
|||
| sharedmain.WebhookMainWithContext(ctx, "domainmapping-webhook", | |||
| sharedmain.WebhookMainWithContext(sharedmain.WithHealthProbesDisabled(ctx), "domainmapping-webhook", | |||
There was a problem hiding this comment.
can we wrap the context on a separate line so it reads better
ctx = sharedmain.WithHealthProbesDisabled(ctx)
| readinessProbe: | ||
| httpGet: | ||
| path: /readiness | ||
| port: probes | ||
| scheme: HTTP | ||
| periodSeconds: 5 | ||
| failureThreshold: 5 | ||
| failureThreshold: 6 |
There was a problem hiding this comment.
I think we want the failureThreshold for readinessProbes to be lower than the failureThreshold for livenessProbes. Otherwise, we're choosing to terminate the container before we remove it from the active set (which was the issue that Julz filed).
There was a problem hiding this comment.
Correct the order of probes tricked me.
|
bump @skonto - release is tomorrow |
|
@dprotaso I will update shortly. |
|
@dprotaso this is ready to stamp. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dprotaso, skonto The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
knative-prow
bot
added
the
approved
* probe fixes * fixes * fix threshold * cleanup
* probe fixes * fixes * fix threshold * cleanup
* probe fixes * fixes * fix threshold * cleanup
* probe fixes * fixes * fix threshold * cleanup
* Deployment probe fixes (knative#13885) * probe fixes * fixes * fix threshold * cleanup * Run `openshift/release/generate-release.sh release-v1.9` --------- Co-authored-by: Stavros Kontopoulos <st.kontopoulos@gmail.com>
