Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DefaultChannelWriter should return Channel instead of ChannelHandlerContext #228

Closed
NiteshKant opened this issue Sep 7, 2014 · 2 comments
Closed

DefaultChannelWriter should return Channel instead of ChannelHandlerContext #228

NiteshKant opened this issue Sep 7, 2014 · 2 comments
Assignees
@NiteshKant
Milestone
0.3.13

Comments

@NiteshKant
Copy link
Member

Returning ChannelHandlerContext is ambiguous as it is unclear which ChannelHandler does this context belong to.

Instead we should return Channel and it is possible to do everything with the Channel interface as it was for ChannelHandlerContext
@NiteshKant NiteshKant self-assigned this Sep 7, 2014
@NiteshKant NiteshKant added this to the 0.3.13 milestone Sep 7, 2014
@NiteshKant
Copy link
Member Author

DefaultChannelWriter.getChannelHandlerContext() will be deprecated as of 0.3.13 and will be removed in 0.3.14 (issue #229)

NiteshKant pushed a commit to NiteshKant/RxNetty that referenced this issue Sep 7, 2014
Fixes ReactiveX#214 ReactiveX#228
447f3f3 
Issue ReactiveX#214 Provde getChannel() method in HttpServerRequest
Issue ReactiveX#228 Provide getChannel() method in DefaultChannelWriter and deprecate getChannelHandlerContext()
@NiteshKant NiteshKant mentioned this issue Sep 7, 2014
Merged
NiteshKant added a commit that referenced this issue Sep 7, 2014
@NiteshKant
Merge pull request #227 from NiteshKant/0.x
136af0d 
Fixes #223 #225 #226 #214 #228 #230
@NiteshKant
Copy link
Member Author

PR #227 deprecates DefaultChannelWriter.getChannelHandlerContext() and adds DefaultChannelWriter#getChannel() method

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@NiteshKant NiteshKant

Labels
None yet
Projects
None yet
Milestone
0.3.13
Development

No branches or pull requests
1 participant
@NiteshKant