Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FlatResponseOperator does not emit any item if there is no content. #230

Closed
NiteshKant opened this issue Sep 7, 2014 · 1 comment
Closed

FlatResponseOperator does not emit any item if there is no content. #230

NiteshKant opened this issue Sep 7, 2014 · 1 comment
Assignees
@NiteshKant
Labels
bug
Milestone
0.3.13

Comments

@NiteshKant
Copy link
Member

FlatResponseOperator must always emit a single item unless it is an error.

The current implementation passes on the onComplete() of content Observable to the subscriber even when there is no content. This causes the subscriber to not even get the HttpClientResponse back.

Instead, the operator must create a ResponseHolder with no content if there is no content in the response.
@NiteshKant NiteshKant added the bug label Sep 7, 2014
@NiteshKant NiteshKant self-assigned this Sep 7, 2014
@NiteshKant NiteshKant added this to the 0.3.13 milestone Sep 7, 2014
@NiteshKant NiteshKant mentioned this issue Sep 7, 2014
Merged
NiteshKant added a commit that referenced this issue Sep 7, 2014
@NiteshKant
Merge pull request #227 from NiteshKant/0.x
136af0d 
Fixes #223 #225 #226 #214 #228 #230
@NiteshKant
Copy link
Member Author

PR #227 fixes this issue and emits a single element (ResponseHolder) in all scenarios but for error.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@NiteshKant NiteshKant

Labels
bug
Projects
None yet
Milestone
0.3.13
Development

No branches or pull requests
1 participant
@NiteshKant