-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate test runner from jasmine to another #1460
Comments
How about power-assert or ava? Their failure dump is informative. |
I'd like to discuss go / no-go first in this discussion. I also have some preferences, but need to be evaluated based on certain requirements such as current toolchain support (coverage, esdocs, etcs) and it can be evaluated once got agreements to go. Though I think it's time to consider, there might be other difficulties I could not think of to block to move on. |
relates to ReactiveX#1460
relates to ReactiveX#1460
relates to ReactiveX#1460
relates to ReactiveX#1460
relates to ReactiveX#1460
relates to ReactiveX#1460
relates to ReactiveX#1460
relates to ReactiveX#1460
relates to ReactiveX#1460
I've had good success with Mocha over the year, it has built in support for promises, so for tests I've done in the past, so async tests can sometimes be as easy as...
|
Given what I saw while working on #1536 ... I find jasmine's fragility to be very disturbing. |
I'm changing this to "high priority" and "PRs welcome" ... but this is NOT at all critical to release, so it's probably not something I'd want anyone tackling in the short term if they're looking to add the most value. |
I'll try this on my end if this can be done relatively quickly. |
relates to ReactiveX#1460
relates to ReactiveX#1460
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Additional information:
It is known jasmine behaves unexpectedly time to time, test cases are fail without exact reason. As similar to recent failures (#1459) just removing test cases into separate file, or modify test execution order makes it passes again. Problem in here is it becomes hard to trust test failures sometimes, cause it's unclear if given assertion failure is due to actual code behavior or simply jasmine's behavior. Maybe it's time to consider to move into different test runner other than jasmine, depends on migration effort.
The text was updated successfully, but these errors were encountered: