Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate test runner from jasmine to another #1460

Closed
kwonoj opened this issue Mar 12, 2016 · 8 comments
Closed

Migrate test runner from jasmine to another #1460

kwonoj opened this issue Mar 12, 2016 · 8 comments
Assignees
Labels
help wanted Issues we wouldn't mind assistance with.

Comments

@kwonoj
Copy link
Member

kwonoj commented Mar 12, 2016

Additional information:

It is known jasmine behaves unexpectedly time to time, test cases are fail without exact reason. As similar to recent failures (#1459) just removing test cases into separate file, or modify test execution order makes it passes again. Problem in here is it becomes hard to trust test failures sometimes, cause it's unclear if given assertion failure is due to actual code behavior or simply jasmine's behavior. Maybe it's time to consider to move into different test runner other than jasmine, depends on migration effort.

@kwonoj kwonoj changed the title Migrate test runner other than jasmine Migrate test runner from jasmine to another Mar 12, 2016
@tetsuharuohzeki
Copy link
Contributor

How about power-assert or ava? Their failure dump is informative.

@kwonoj
Copy link
Member Author

kwonoj commented Mar 14, 2016

I'd like to discuss go / no-go first in this discussion. I also have some preferences, but need to be evaluated based on certain requirements such as current toolchain support (coverage, esdocs, etcs) and it can be evaluated once got agreements to go. Though I think it's time to consider, there might be other difficulties I could not think of to block to move on.

kwonoj added a commit to kwonoj/rxjs that referenced this issue Mar 18, 2016
kwonoj added a commit to kwonoj/rxjs that referenced this issue Mar 18, 2016
kwonoj added a commit to kwonoj/rxjs that referenced this issue Mar 19, 2016
kwonoj added a commit to kwonoj/rxjs that referenced this issue Mar 21, 2016
kwonoj added a commit to kwonoj/rxjs that referenced this issue Mar 21, 2016
kwonoj added a commit to kwonoj/rxjs that referenced this issue Mar 21, 2016
kwonoj added a commit to kwonoj/rxjs that referenced this issue Mar 21, 2016
kwonoj added a commit to kwonoj/rxjs that referenced this issue Mar 21, 2016
kwonoj added a commit to kwonoj/rxjs that referenced this issue Mar 23, 2016
@david-driscoll
Copy link
Member

I've had good success with Mocha over the year, it has built in support for promises, so for tests I've done in the past, so async tests can sometimes be as easy as...

it('should return 0', () => {
  return Observable.of(1).toPromise().then(result => expect(result).to.be.eql(1));
});

@benlesh
Copy link
Member

benlesh commented Mar 25, 2016

Given what I saw while working on #1536 ... I find jasmine's fragility to be very disturbing.

@benlesh benlesh added help wanted Issues we wouldn't mind assistance with. priority: high and removed type: discussion labels Mar 25, 2016
@benlesh
Copy link
Member

benlesh commented Mar 25, 2016

I'm changing this to "high priority" and "PRs welcome" ... but this is NOT at all critical to release, so it's probably not something I'd want anyone tackling in the short term if they're looking to add the most value.

@kwonoj
Copy link
Member Author

kwonoj commented Mar 26, 2016

I'll try this on my end if this can be done relatively quickly.

kwonoj added a commit to kwonoj/rxjs that referenced this issue Mar 27, 2016
@kwonoj kwonoj self-assigned this Mar 28, 2016
kwonoj added a commit to kwonoj/rxjs that referenced this issue Mar 28, 2016
@kwonoj
Copy link
Member Author

kwonoj commented Mar 31, 2016

Closing this via #1545. One remaining issue is being tracked separately via #1549.

@kwonoj kwonoj closed this as completed Mar 31, 2016
@lock
Copy link

lock bot commented Jun 7, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Jun 7, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
help wanted Issues we wouldn't mind assistance with.
Projects
None yet
Development

No branches or pull requests

4 participants