Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pin build dependencies to known-working versions #550

Closed
benlesh opened this issue Oct 16, 2015 · 0 comments
Closed

Pin build dependencies to known-working versions #550

benlesh opened this issue Oct 16, 2015 · 0 comments
Labels
help wanted Issues we wouldn't mind assistance with.

Comments

@benlesh
Copy link
Member

benlesh commented Oct 16, 2015

There is a comment here that describes an issue I had where eslint upgraded to 1.7.0 when I wiped my node_modules directory and reinstalled. 1.7.0 had some false positives. I don't want that to happen to others while trying to create PRs, so I think it's best that we pin our build dependencies to highest known working versions.
@benlesh benlesh added the help wanted Issues we wouldn't mind assistance with. label Oct 16, 2015
kwonoj added a commit to kwonoj/rxjs that referenced this issue Oct 16, 2015
@kwonoj
chore(package.json): pin dev dependency package to known good
fa0d985 
closes ReactiveX#550
@kwonoj kwonoj mentioned this issue Oct 16, 2015
Closed
kwonoj added a commit to kwonoj/rxjs that referenced this issue Oct 16, 2015
@kwonoj
chore(package.json): pin dev dependency package to known good
c151cf3 
closes ReactiveX#550
kwonoj added a commit to kwonoj/rxjs that referenced this issue Oct 16, 2015
@kwonoj
chore(package.json): pin dev dependency package to known good
0dd7457 
closes ReactiveX#550
@kwonoj kwonoj mentioned this issue Oct 30, 2015
Closed
@lock lock bot locked as resolved and limited conversation to collaborators Jun 7, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
help wanted Issues we wouldn't mind assistance with.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore(package.json): pin dev dependency package to known good kwonoj/rxjs
1 participant
@benlesh