Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(operators): write comprehensive JSDoc on the buffer operators #1485

Closed
wants to merge 2 commits into from

Conversation

staltz
Copy link
Member

@staltz staltz commented Mar 18, 2016

Merge after PR #1473 is merged

@coveralls
Copy link

Coverage Status

Coverage remained the same at 95.981% when pulling 02957d3 on staltz:buffer-docs into 8a8d0f0 on ReactiveX:master.

* However, when a new nested Observable is emitted, `switch` stops emitting
* items from the earlier-emitted nested Observable and begins emitting items
* from the new one. It continues to behave like this for subsequent nested
* Observables.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will it makes sense to mention switch also handles subscription when switching occurs? I remember someone have asked if it's needed to explicitly manage inner subscription after switching.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point. But let's talk about this in PR #1473 which is the one that has the commit for switch.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool :)

@coveralls
Copy link

Coverage Status

Coverage remained the same at 95.982% when pulling dc1c210 on staltz:buffer-docs into d9855e2 on ReactiveX:master.

@kwonoj
Copy link
Member

kwonoj commented Mar 21, 2016

Merged with 56c9191, thanks @staltz

@kwonoj kwonoj closed this Mar 21, 2016
@staltz staltz deleted the buffer-docs branch March 21, 2016 17:20
@lock
Copy link

lock bot commented Jun 7, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Jun 7, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants