docs(operators): write comprehensive JSDoc on window operators #1489
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'll check in #1473 soon. (May require another rebase?) |
|
No problem to rebase IMO |
staltz
changed the title
| * var result = clicks.windowCount(3) | ||
| * .map(win => win.skip(1)) // skip first of every 3 clicks | ||
| * .mergeAll(); // flatten the Observable-of-Observables | ||
| * result.subscribe(x => console.log(x)); |
There was a problem hiding this comment.
Haha.. this example. We should probably come up with something better at some point. But this will do for now. I look at this and think "why not clicks.filter((_, i) => i % 3 !== 2)?"
There was a problem hiding this comment.
It's duper hard to find small examples and not make it even a little bit contrived. I started to question even the purpose of some operators, if anyway you can solve the problem with other operators.
|
LGTM |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge after PR #1473 is merged