fix(WebSocketSubject): WebSocketSubject will now chain operators prop…

[benlesh]

Removed the custom lift method from WebSocketSubject. This is the quick and dirty fix for #1745. I think this class needs to be refactored again so it no longer overwrites it's own destination.

[rgbkrk]

Awesome, thanks.

[trxcllnt]

@Blesh isn't the real culprit here the incomplete WebSocketSubject constructor? It doesn't set this.source if the first parameter is an Observable, and the optional second parameter destination is ignored entirely.

[benlesh]

@trxcllnt so you're saying here, we could add a check to see if destination is passed and if so, use that, otherwise use the ReplaySubject?

[trxcllnt]

@Blesh yes I think that should work. and probably shouldn't do the assign() if the first argument is an Observable.

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.