fix(windowTime): clean up closed window with timeSpanOnly #2240
Conversation
|
Not sure how to test this cases? :/ |
| const { subscriber, windowTimeSpan, window } = state; | ||
| if (window) { | ||
| window.complete(); | ||
| subscriber.closeWindow(window); |
There was a problem hiding this comment.
@kwonoj should've probably saved all of the typing refactors and formatting stuff for a different commit. It's hard for me to see what the "meat" of this PR is.. I'm assuming it's mostly this line here?
There was a problem hiding this comment.
yes, correct. previously timspan'ed window closed, but not teared down as same as default window behavior. Now both uses same teardown path. Sorry for creating commit include mixed changes, should I split up and update PR?
There was a problem hiding this comment.
Yeah, we might want to. This is a commit to merge in a fix to production code... so we might want to make sure the changes are isolated this time.
There was a problem hiding this comment.
will do. I'll rather create as separate PR to have better scoped clarity.
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Description:
This PR adds cleanup to
windowTimeoperator to clear up closed instance of window when invoked via timespan only.Related issue (if exists):