fixes for typescript 2.4 #2780
Merged
fixes for typescript 2.4 #2780
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by 🚫 dangerJS |
-+1.0KB-red.svg?style=flat-square){kind=icon}
-+0.4KB-red.svg?style=flat-square){kind=icon}
TypeScript 2.4 is more strict about assignability with generics,
and in some cases (when calling a generic function) it will infer
that the generic parameter is <{}> rather than the <T> that rxjs
typically wants.
Fix this by explicitly passing <T> in the cases where compilation
fails.
GulajavaMinistudio
added a commit
to GulajavaMinistudio/rxjs
that referenced
this pull request
Aug 4, 2017
fix(compilation): compile under typescript 2.4 (ReactiveX#2780)
hermanbanken
pushed a commit
to hermanbanken/RxJS
that referenced
this pull request
Aug 7, 2017
TypeScript 2.4 is more strict about assignability with generics,
and in some cases (when calling a generic function) it will infer
that the generic parameter is <{}> rather than the <T> that rxjs
typically wants.
Fix this by explicitly passing <T> in the cases where compilation
fails.
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TypeScript 2.4 is more strict about assignability with generics,
and in some cases (when calling a generic function) it will infer
that the generic parameter is <{}> rather than the that rxjs
typically wants.
Fix this by explicitly passing in the cases where compilation
fails.
Description:
Related issue (if exists):