-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(of): deprecation warning when using of as intended #4724
Conversation
Pull Request Test Coverage Report for Build 8470
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but I have one minor change request.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@cartant @evertbouw , can we change the PR to remove deprecation warnings for the other methods that also don't pass a scheduler (e.g. from, concat, merge, startWith and endWith)? From #4595:
I assume the variants that don't pass a scheduler should not be deprecated? |
@mtraynham If there is a specific problem with the operators you are talking about, please open another issue and fill out the template with the specifics. As it stands, I don't have all of the information and I don't want to spend anytime looking into this based on what I've assumed you are talking about. Note that the |
Description:
Typescript picks the deprecated signature when using
of
.By moving the signature to the bottom it will pick the correct one.Removed the deprecation comment insteadRelated issue (if exists):
closes #4723