fix(pipe): Special handling for 0-arg case. #4936
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cartant
reviewed
Jul 27, 2019
|
The right predictable behavior may be to throw an error. The sum of an
empty collection of numbers is 0, but what is the sum of a null of numbers?
… |
I'm fine with it throwing an error. I just don't think it should return a no-op. Given that the type signature requires an array to be passed, I think removing the entire |
The check is never reached in internal code, and is not exported for external code. The behavior is not tested for, and arguably wrong.
|
Removed the check for nonexistent array argument. |
|
Oh, I see, we wanted to keep the error on the |
benlesh
approved these changes
Aug 21, 2019
benlesh
added a commit
that referenced
this pull request
Apr 3, 2020
* fix(pipe): Special handling for 0 args. * test(pipe): Fix test label for 0-arg. * fix(pipe): Remove check for missing args array. The check is never reached in internal code, and is not exported for external code. The behavior is not tested for, and arguably wrong. * fix(pipe): no argument case run-time check * refactor: revert checking for lack of array argument Co-authored-by: Ben Lesh <ben@benlesh.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Optimize calling
pipewith 0 args.Closes #4933
There is an
if (!fns)check in thepipeFromArrayhelper, and it results innoop. The test forpipesays the 0-arg case returns a no-op, but it checks foridentity. The test is probably meant to test for that check, but the check is for the lack of an args array, so I added a check for that test to test and fixed the test's label.The
if (!fns)check might not be necessary at all. It is unreachable from client code, sincepipeFromArrayis internal, and is only used frompipe, which will never pass null/undefined.