Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(fetch): don't leak event listeners added to passed-in signals #5305

Merged
merged 3 commits into from
Apr 3, 2020
Merged

fix(fetch): don't leak event listeners added to passed-in signals #5305

merged 3 commits into from
Apr 3, 2020

Conversation

cartant
Copy link
Collaborator

@cartant cartant commented Feb 9, 2020

Description:

This PR adds a failing test and ensures that removeEventListener is called upon unsubscription if addEventListener was called on a passed in AbortSignal.

Related issue: None

@cartant cartant requested a review from benlesh February 9, 2020 06:21
@cartant cartant changed the title fix(fetch): call removeEventListener on passed-in signals fix(fetch): don't leak event listeners added to passed-in signals Feb 9, 2020
@cartant cartant mentioned this pull request Feb 9, 2020
Merged
@benlesh benlesh merged commit d4d6c47 into ReactiveX:master Apr 3, 2020
benlesh pushed a commit that referenced this pull request Apr 3, 2020
@cartant @benlesh
fix(fetch): don't leak event listeners added to passed-in signals (#5305
06bf3a3 
)

* test(fetch): add failing test

* fix(fetch): don't leak signal listeners

* chore: improve an existing test's description
@lock lock bot locked as resolved and limited conversation to collaborators May 5, 2020
@cartant cartant deleted the fix-fetch-leak branch September 24, 2020 07:09
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@benlesh benlesh benlesh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cartant @benlesh