Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(combineLatest): accept array of observable as parameter #759

Merged
merged 1 commit into from
Nov 22, 2015

Conversation

kwonoj
Copy link
Member

@kwonoj kwonoj commented Nov 20, 2015

closes #594

Applies same mechanics of forkJoin to support array of observables, to close issue.

@benlesh
Copy link
Member

benlesh commented Nov 21, 2015

LGTM

@benlesh
Copy link
Member

benlesh commented Nov 21, 2015

I presume that this didn't affect perf in any meaningful way (similar to the forkJoin change)?

@kwonoj
Copy link
Member Author

kwonoj commented Nov 21, 2015

I presume that this didn't affect perf in any meaningful way (similar to the forkJoin change)?

: yes, forgot to attach number in general number differences are acceptable in bounds.

before

                                 RxJS 4.0.7 | RxJS 5.0.0-alpha.10 |          factor |      % improved
-------------------------------------------------------------------------------------------------------
combinelatest - immediate | 6,340 (±13.40%) |     57,265 (±9.28%) |           9.03x |         803.2%
            combinelatest |  6,035 (±9.18%) |    46,885 (±12.88%) |           7.77x |         676.9%

after

                                 RxJS 4.0.7 | RxJS 5.0.0-alpha.10 |          factor |      % improved
-------------------------------------------------------------------------------------------------------
combinelatest - immediate | 6,340 (±17.19%) |     55,761 (±9.41%) |           8.79x |          779.4%
            combinelatest | 8,274 (±11.69%) |     48,748 (±6.96%) |           5.89x |          489.2%

I'll check in changes myself around tonight - tomorrow.

@kwonoj kwonoj merged commit 2edd92c into ReactiveX:master Nov 22, 2015
@kwonoj
Copy link
Member Author

kwonoj commented Nov 22, 2015

Merged with 2edd92c.

@kwonoj kwonoj deleted the feat-combinelatest branch November 22, 2015 19:06
@lock lock bot locked as resolved and limited conversation to collaborators Jan 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

forkJoin operator doesn't accept an array of observables
2 participants