fix(expand): accept scheduler parameter #858
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -22,12 +26,25 @@ export class ExpandSubscriber<T, R> extends OuterSubscriber<T, R> { | |||
| private active: number = 0; | |||
| private hasCompleted: boolean = false; | |||
| private buffer: any[]; | |||
| private _concurrent: number = Number.POSITIVE_INFINITY; | |||
There was a problem hiding this comment.
is it necessarily required to have 2 fields, _concurrent and concurrent?
There was a problem hiding this comment.
It is not. I'll fix it.
Also moves the handling of the default value for optional parameters to the expand function instead of the operator's ctor. Closes ReactiveX#841.
luisgabriel
force-pushed
the
expand-scheduler
branch
from
81117b7
to
1d6ca4c
Compare
luisgabriel
changed the title
|
Just updated this PR addressing the previous comments. Still missing some test cases using a custom scheduler. Suggestion are very welcome. ;) |
| @@ -46,19 +53,26 @@ export class ExpandSubscriber<T, R> extends OuterSubscriber<T, R> { | |||
| let result = tryCatch(this.project)(value, index); | |||
| if (result === errorObject) { | |||
| destination.error(result.e); | |||
| } else if (!this.scheduler) { | |||
| this.subscribeToProjection(result, value, index); | |||
There was a problem hiding this comment.
Looks like we've lost the scalar optimization for this branch of code. if (result._isScalar) { ...etc.
There was a problem hiding this comment.
It was moved to subscribeToProjection().
|
Merged with 79e9084. Thanks @luisgabriel! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also moves the handling of the default value for optional parameters to
the expand function instead of the operator's ctor.
Closes #841.