modern python #65
modern python #65
Conversation
circleci docker build and publish build instructions
|
This pull request fixes 3 alerts when merging 34c46b5 into 6486d6e - view on LGTM.com fixed alerts:
|
|
This pull request fixes 3 alerts when merging 3ca1c7e into 6486d6e - view on LGTM.com fixed alerts:
|
|
This pull request fixes 3 alerts when merging 044fa97 into 6486d6e - view on LGTM.com fixed alerts:
|
Codecov Report
@@ Coverage Diff @@
## master #65 +/- ##
=======================================
Coverage 96.90% 96.90%
=======================================
Files 8 8
Lines 776 776
=======================================
Hits 752 752
Misses 24 24 Continue to review full report at Codecov.
|
|
@DvirDukhan Can you modify the merge requirements so that this depends on ci/circleci:build-latest rather that build? |
|
This pull request introduces 1 alert and fixes 3 when merging b9b31e3 into 6486d6e - view on LGTM.com new alerts:
fixed alerts:
|
|
This pull request introduces 1 alert and fixes 3 when merging fbc5cda into 6486d6e - view on LGTM.com new alerts:
fixed alerts:
|
removing second poetry build call, since they can be done in one
|
This pull request introduces 1 alert and fixes 3 when merging db860f6 into 6486d6e - view on LGTM.com new alerts:
fixed alerts:
|
|
This pull request introduces 1 alert and fixes 3 when merging a313a28 into 3a7d3a6 - view on LGTM.com new alerts:
fixed alerts:
|
|
This pull request introduces 1 alert and fixes 3 when merging 5bf1426 into 3a7d3a6 - view on LGTM.com new alerts:
fixed alerts:
|
|
This pull request fixes 3 alerts when merging 0509bda into 3a7d3a6 - view on LGTM.com fixed alerts:
|
|
@DvirDukhan This is ready, we've merged in the fix. Can you (please) change the repo requirement to no longer be dependent on ci/circleci:build and instead require ci/circleci:build-latest, as part of this. While I can slam it in - I'd like a review. |
|
This pull request fixes 3 alerts when merging 98fdac3 into 3a7d3a6 - view on LGTM.com fixed alerts:
|
|
This pull request fixes 3 alerts when merging 4649986 into 3a7d3a6 - view on LGTM.com fixed alerts:
|
|
This pull request fixes 3 alerts when merging ce54a7f into 3a7d3a6 - view on LGTM.com fixed alerts:
|
|
This pull request fixes 3 alerts when merging e335fff into 3a7d3a6 - view on LGTM.com fixed alerts:
|
|
|
||
| abort_for_noci: |
There was a problem hiding this comment.
is this a generic name across all the clients? if not can we rename to abort_tests?
There was a problem hiding this comment.
This is the generic name currently in use in all clients.
| @@ -0,0 +1,20 @@ | |||
| ARG OSNICK=bionic | |||
There was a problem hiding this comment.
why do we need this file?
There was a problem hiding this comment.
A future goal - I'd like to build dockers out of these, and given people a one stop shop. We are not currently using it.
| @@ -1,3 +1,3 @@ | |||
| from .client import Client | |||
| from .client import Client # noqa | |||
There was a problem hiding this comment.
#noqa tells the python linter to not ignore this specific line. It sets off a linter error but is required.
|
Kudos, SonarCloud Quality Gate passed!
|
|
This pull request fixes 3 alerts when merging ec89579 into 3a7d3a6 - view on LGTM.com fixed alerts:
|
Modern build system for python components. This includes linters, security scanning, and parallel builds across supported versions.
Also, by fixing linter errors.
closes #70
closes #71