Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: bundling multiple files specified as CLI arguments #1717

Merged
merged 10 commits into from
Sep 6, 2024

Conversation

tatomyr
Copy link
Contributor

@tatomyr tatomyr commented Sep 6, 2024

What/Why/How?

Fixed a bug where bundling multiple API description files specified as CLI arguments, along with the --output option, stored the result in a single file instead of a folder.

Reference

Fixes #1715

The original bug was introduced in #1708

Testing

Screenshots (optional)

Check yourself

  • Code changed? - Tested with redoc/reference-docs/workflows (internal)
  • All new/updated code is covered with tests
  • New package installed? - Tested in different environments (browser/node)

Security

  • Security impact of change has been considered
  • Code follows company security practices and guidelines

@tatomyr tatomyr self-assigned this Sep 6, 2024
@tatomyr tatomyr requested review from a team as code owners September 6, 2024 13:29
Copy link

changeset-bot bot commented Sep 6, 2024

🦋 Changeset detected

Latest commit: 559c5c5

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@redocly/cli Patch
@redocly/openapi-core Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@tatomyr tatomyr requested a review from RomanHotsiy September 6, 2024 13:29
Copy link
Contributor

github-actions bot commented Sep 6, 2024

Command Mean [s] Min [s] Max [s] Relative
redocly lint packages/core/src/benchmark/benches/rebilly.yaml 1.015 ± 0.026 0.990 1.078 1.01 ± 0.03
redocly-next lint packages/core/src/benchmark/benches/rebilly.yaml 1.008 ± 0.017 0.979 1.036 1.00

docs/commands/bundle.md Outdated Show resolved Hide resolved
@JLekawa JLekawa self-requested a review September 6, 2024 13:38
docs/commands/bundle.md Outdated Show resolved Hide resolved
tatomyr and others added 2 commits September 6, 2024 16:43
Co-authored-by: Jacek Łękawa <164185257+JLekawa@users.noreply.github.com>
Co-authored-by: Jacek Łękawa <164185257+JLekawa@users.noreply.github.com>
docs/commands/bundle.md Outdated Show resolved Hide resolved
docs/commands/bundle.md Outdated Show resolved Hide resolved
tatomyr and others added 2 commits September 6, 2024 16:45
Co-authored-by: Jacek Łękawa <164185257+JLekawa@users.noreply.github.com>
Co-authored-by: Jacek Łękawa <164185257+JLekawa@users.noreply.github.com>
Copy link
Contributor

github-actions bot commented Sep 6, 2024

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements 78.34% 4901/6256
🟡 Branches 67.05% 2027/3023
🟡 Functions 72.62% 809/1114
🟡 Lines 78.64% 4623/5879
Show files with reduced coverage 🔻
St.
File Statements Branches Functions Lines
🟡
... / miscellaneous.ts
68.29%
59.83% (+1.65% 🔼)
71.7% 68.05%

Test suite run success

794 tests passing in 118 suites.

Report generated by 🧪jest coverage report action from 559c5c5

docs/commands/bundle.md Outdated Show resolved Hide resolved
docs/commands/bundle.md Outdated Show resolved Hide resolved
docs/commands/bundle.md Outdated Show resolved Hide resolved
tatomyr and others added 4 commits September 6, 2024 17:04
Co-authored-by: Jacek Łękawa <164185257+JLekawa@users.noreply.github.com>
Co-authored-by: Jacek Łękawa <164185257+JLekawa@users.noreply.github.com>
Co-authored-by: Jacek Łękawa <164185257+JLekawa@users.noreply.github.com>
@tatomyr tatomyr merged commit 0eee406 into main Sep 6, 2024
33 checks passed
@tatomyr tatomyr deleted the fix/bundling-multiple-apis branch September 6, 2024 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New minor 1.23.0 release causes breaking change in bundle output option
4 participants