fix(model-server): make specifying a key ID optional #1039
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results 179 files 179 suites 23m 52s ⏱️ Results for commit 069ee0b. ♻️ This comment has been updated with latest results. |
odzhychko
force-pushed
the
fix/MODELIX-1016
branch
from
e678ba8 to
87d0a1a
Compare
|
The build is broken because of new bug in Redocly. |
odzhychko
force-pushed
the
fix/MODELIX-1016
branch
from
87d0a1a to
df38491
Compare
JVM coverage report
|
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
authorization/src/main/kotlin/org/modelix/authorization/AuthorizationConfig.kt
Fixed
Show fixed
Hide fixed
authorization/src/main/kotlin/org/modelix/authorization/AuthorizationConfig.kt
Fixed
Show fixed
Hide fixed
authorization/src/main/kotlin/org/modelix/authorization/AuthorizationConfig.kt
Fixed
Show fixed
Hide fixed
odzhychko
force-pushed
the
fix/MODELIX-1016
branch
3 times, most recently
from
1fa7789 to
837d64f
Compare
authorization/src/main/kotlin/org/modelix/authorization/AuthorizationPlugin.kt
Fixed
Show fixed
Hide fixed
odzhychko
force-pushed
the
fix/MODELIX-1016
branch
from
837d64f to
d5457d5
Compare
languitar
reviewed
Sep 23, 2024
model-server/src/test/kotlin/org/modelix/model/server/AuthorizationTest.kt
Show resolved
Hide resolved
model-server/src/test/kotlin/org/modelix/model/server/AuthorizationTest.kt
Outdated
Show resolved
Hide resolved
model-server/src/test/kotlin/org/modelix/model/server/AuthorizationTest.kt
Outdated
Show resolved
Hide resolved
model-server/src/test/kotlin/org/modelix/model/server/AuthorizationTest.kt
Outdated
Show resolved
Hide resolved
authorization/src/main/kotlin/org/modelix/authorization/AuthorizationConfig.kt
Outdated
Show resolved
Hide resolved
odzhychko
force-pushed
the
fix/MODELIX-1016
branch
from
d5457d5 to
026cd78
Compare
If no static key ID is configured, then the key ID specified in the JWT is used to verify the token. The key is looked up at the JWK URL with the key ID from the token. This is a fix because it restores functionality that accidentally broke in version 8.14.0.
The logic determining the verifier was a duplicate of the logic used in the additional validation. The logic from the validation (aka `ModelixAuthorizationConfig,nullIfInvalid`) is also used elsewhere. For example, it is used in the workspaces through the modelix-authorization lib. So it was reused in a custom verifier. Calling `ModelixAuthorizationConfig.nullIfInvalid` again in `validate` is redundant. It is now only used to create a custom principal object.
slisson
force-pushed
the
fix/MODELIX-1016
branch
from
026cd78 to
069ee0b
Compare
slisson
approved these changes
Nov 6, 2024
|
🎉 This PR is included in version 9.1.3 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If no static key ID is configured, then the key ID specified in the JWT is used to verify the token. The key is looked up at the JWK URL with the key ID from the token.
This is a fix because it restores functionality that accidentally broke in version 8.14.0.
To be verified by reviewers