Skip to content

TypeScript generator: Use string type as the discriminator property type in specialized interfaces #260

TypeScript generator: Use string type as the discriminator property type in specialized interfaces

TypeScript generator: Use string type as the discriminator property type in specialized interfaces #260

Triggered via pull request July 17, 2024 13:34
Status Failure
Total duration 6m 37s
Artifacts

pr.yml

on: pull_request
Fit to window
Zoom out
Zoom in

Annotations

10 errors and 22 warnings
ubuntu-latest
[xUnit.net 00:00:00.60] NJsonSchema.CodeGeneration.Tests.EnumGenerationTests.When_enum_has_string_value_then_TS_code_has_string_value [FAIL]
ubuntu-latest
[xUnit.net 00:00:00.98] NJsonSchema.CodeGeneration.TypeScript.Tests.TypeScriptDiscriminatorTests.When_generating_interface_contract_add_discriminator [FAIL]
ubuntu-latest
Target "Test" has thrown an exception
ubuntu-latest
Process completed with exit code 255.
windows-latest
[xUnit.net 00:00:00.56] NJsonSchema.CodeGeneration.Tests.EnumGenerationTests.When_enum_has_string_value_then_TS_code_has_string_value [FAIL]
windows-latest
[xUnit.net 00:00:00.81] NJsonSchema.CodeGeneration.TypeScript.Tests.TypeScriptDiscriminatorTests.When_generating_interface_contract_add_discriminator [FAIL]
windows-latest
[xUnit.net 00:00:08.09] NJsonSchema.CodeGeneration.Tests.EnumGenerationTests.When_enum_has_string_value_then_TS_code_has_string_value [FAIL]
windows-latest
[xUnit.net 00:00:05.25] NJsonSchema.CodeGeneration.TypeScript.Tests.TypeScriptDiscriminatorTests.When_generating_interface_contract_add_discriminator [FAIL]
windows-latest
Target "Test" has thrown an exception
windows-latest
Process completed with exit code 1.
ubuntu-latest
The following actions uses Node.js version which is deprecated and will be forced to run on node20: actions/checkout@v3, actions/cache@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
ubuntu-latest
/home/runner/work/NJsonSchema/NJsonSchema/src/NJsonSchema.Yaml.Tests/References/YamlReferencesTests.cs(21,27): warning CA1707: Remove the underscores from member name NJsonSchema.Yaml.Tests.References.LocalReferencesTests.When_yaml_schema_has_references_it_works(string, string) (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1707) [/home/runner/work/NJsonSchema/NJsonSchema/src/NJsonSchema.Yaml.Tests/NJsonSchema.Yaml.Tests.csproj::TargetFramework=net8.0]
ubuntu-latest
/home/runner/work/NJsonSchema/NJsonSchema/src/NJsonSchema.Yaml.Tests/References/YamlReferencesTests.cs(69,27): warning CA1707: Remove the underscores from member name NJsonSchema.Yaml.Tests.References.LocalReferencesTests.When_yaml_OpenAPI_spec_is__served_with_gzip_compression__it_works(string, string) (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1707) [/home/runner/work/NJsonSchema/NJsonSchema/src/NJsonSchema.Yaml.Tests/NJsonSchema.Yaml.Tests.csproj::TargetFramework=net8.0]
ubuntu-latest
/home/runner/work/NJsonSchema/NJsonSchema/src/NJsonSchema.Yaml.Tests/References/YamlReferencesTests.cs(83,27): warning CA1707: Remove the underscores from member name NJsonSchema.Yaml.Tests.References.LocalReferencesTests.When_yaml_OpenAPI_spec_has_relative_external_schema_refs_in_subdirs__they_are_resolved(string) (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1707) [/home/runner/work/NJsonSchema/NJsonSchema/src/NJsonSchema.Yaml.Tests/NJsonSchema.Yaml.Tests.csproj::TargetFramework=net8.0]
ubuntu-latest
/home/runner/work/NJsonSchema/NJsonSchema/src/NJsonSchema.Yaml.Tests/References/YamlReferencesTests.cs(38,27): warning CA1707: Remove the underscores from member name NJsonSchema.Yaml.Tests.References.LocalReferencesTests.When_yaml_OpenAPI_spec_has_external_schema_refs_they_are_resolved(string, string, string) (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1707) [/home/runner/work/NJsonSchema/NJsonSchema/src/NJsonSchema.Yaml.Tests/NJsonSchema.Yaml.Tests.csproj::TargetFramework=net8.0]
ubuntu-latest
/home/runner/work/NJsonSchema/NJsonSchema/src/NJsonSchema.Yaml.Tests/References/YamlReferencesTests.cs(115,24): warning CA1822: Member 'GetTestDirectory' does not access instance data and can be marked as static (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1822) [/home/runner/work/NJsonSchema/NJsonSchema/src/NJsonSchema.Yaml.Tests/NJsonSchema.Yaml.Tests.csproj::TargetFramework=net8.0]
ubuntu-latest
/home/runner/work/NJsonSchema/NJsonSchema/src/NJsonSchema.Tests/Converters/JsonExceptionConverterTests.cs(26,23): warning CA1507: Use nameof in place of string literal 'CompanyKey' (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1507) [/home/runner/work/NJsonSchema/NJsonSchema/src/NJsonSchema.Tests/NJsonSchema.Tests.csproj::TargetFramework=net8.0]
ubuntu-latest
/home/runner/work/NJsonSchema/NJsonSchema/src/NJsonSchema.Tests/Generation/ArrayGenerationTests.cs(36,52): warning CA1825: Avoid unnecessary zero-length array allocations. Use Array.Empty<string>() instead. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1825) [/home/runner/work/NJsonSchema/NJsonSchema/src/NJsonSchema.Tests/NJsonSchema.Tests.csproj::TargetFramework=net8.0]
ubuntu-latest
/home/runner/work/NJsonSchema/NJsonSchema/src/NJsonSchema.Tests/Generation/AttributeGenerationTests.cs(230,22): warning CA1711: Rename type name ClassWithDictionary so that it does not end in 'Dictionary' (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1711) [/home/runner/work/NJsonSchema/NJsonSchema/src/NJsonSchema.Tests/NJsonSchema.Tests.csproj::TargetFramework=net8.0]
ubuntu-latest
/home/runner/work/NJsonSchema/NJsonSchema/src/NJsonSchema.Tests/Generation/IgnoredPropertyTests.cs(15,27): warning CA1051: Do not declare visible instance fields (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1051) [/home/runner/work/NJsonSchema/NJsonSchema/src/NJsonSchema.Tests/NJsonSchema.Tests.csproj::TargetFramework=net8.0]
ubuntu-latest
/home/runner/work/NJsonSchema/NJsonSchema/src/NJsonSchema.Tests/Generation/IgnoredPropertyTests.cs(18,27): warning CA1051: Do not declare visible instance fields (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1051) [/home/runner/work/NJsonSchema/NJsonSchema/src/NJsonSchema.Tests/NJsonSchema.Tests.csproj::TargetFramework=net8.0]
windows-latest
The following actions uses Node.js version which is deprecated and will be forced to run on node20: actions/checkout@v3, actions/cache@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
windows-latest
D:\a\NJsonSchema\NJsonSchema\src\NJsonSchema.NewtonsoftJson.Tests\Generation\StructTests.cs(18,47): warning CA1051: Do not declare visible instance fields (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1051) [D:\a\NJsonSchema\NJsonSchema\src\NJsonSchema.NewtonsoftJson.Tests\NJsonSchema.NewtonsoftJson.Tests.csproj::TargetFramework=net462]
windows-latest
D:\a\NJsonSchema\NJsonSchema\src\NJsonSchema.NewtonsoftJson.Tests\Generation\StructTests.cs(21,48): warning CA1051: Do not declare visible instance fields (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1051) [D:\a\NJsonSchema\NJsonSchema\src\NJsonSchema.NewtonsoftJson.Tests\NJsonSchema.NewtonsoftJson.Tests.csproj::TargetFramework=net462]
windows-latest
D:\a\NJsonSchema\NJsonSchema\src\NJsonSchema.NewtonsoftJson.Tests\Generation\StructTests.cs(25,21): warning CA1707: Remove the underscores from member name NJsonSchema.NewtonsoftJson.Tests.Generation.StructTests.Should_have_a_shared_struct_schema() (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1707) [D:\a\NJsonSchema\NJsonSchema\src\NJsonSchema.NewtonsoftJson.Tests\NJsonSchema.NewtonsoftJson.Tests.csproj::TargetFramework=net462]
windows-latest
D:\a\NJsonSchema\NJsonSchema\src\NJsonSchema.NewtonsoftJson.Tests\Generation\StructTests.cs(34,13): warning xUnit2013: Do not use Assert.Equal() to check for collection size. Use Assert.Single instead. (https://xunit.net/xunit.analyzers/rules/xUnit2013) [D:\a\NJsonSchema\NJsonSchema\src\NJsonSchema.NewtonsoftJson.Tests\NJsonSchema.NewtonsoftJson.Tests.csproj::TargetFramework=net462]
windows-latest
D:\a\NJsonSchema\NJsonSchema\src\NJsonSchema.NewtonsoftJson.Tests\Generation\RecordTests.cs(14,21): warning CA1707: Remove the underscores from member name NJsonSchema.NewtonsoftJson.Tests.Generation.RecordTests.Should_have_only_one_property() (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1707) [D:\a\NJsonSchema\NJsonSchema\src\NJsonSchema.NewtonsoftJson.Tests\NJsonSchema.NewtonsoftJson.Tests.csproj::TargetFramework=net462]
windows-latest
D:\a\NJsonSchema\NJsonSchema\src\NJsonSchema.NewtonsoftJson.Tests\Generation\RecordTests.cs(23,13): warning xUnit2013: Do not use Assert.Equal() to check for collection size. Use Assert.Single instead. (https://xunit.net/xunit.analyzers/rules/xUnit2013) [D:\a\NJsonSchema\NJsonSchema\src\NJsonSchema.NewtonsoftJson.Tests\NJsonSchema.NewtonsoftJson.Tests.csproj::TargetFramework=net462]
windows-latest
D:\a\NJsonSchema\NJsonSchema\src\NJsonSchema.Tests\Converters\JsonExceptionConverterTests.cs(26,23): warning CA1507: Use nameof in place of string literal 'CompanyKey' (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1507) [D:\a\NJsonSchema\NJsonSchema\src\NJsonSchema.Tests\NJsonSchema.Tests.csproj::TargetFramework=net462]
windows-latest
D:\a\NJsonSchema\NJsonSchema\src\NJsonSchema.Tests\Generation\ArrayGenerationTests.cs(36,52): warning CA1825: Avoid unnecessary zero-length array allocations. Use Array.Empty<string>() instead. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1825) [D:\a\NJsonSchema\NJsonSchema\src\NJsonSchema.Tests\NJsonSchema.Tests.csproj::TargetFramework=net462]
windows-latest
D:\a\NJsonSchema\NJsonSchema\src\NJsonSchema.Tests\Generation\AttributeGenerationTests.cs(230,22): warning CA1711: Rename type name ClassWithDictionary so that it does not end in 'Dictionary' (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1711) [D:\a\NJsonSchema\NJsonSchema\src\NJsonSchema.Tests\NJsonSchema.Tests.csproj::TargetFramework=net462]
windows-latest
D:\a\NJsonSchema\NJsonSchema\src\NJsonSchema.Tests\Generation\EnumTests.cs(54,22): warning CA1711: Rename type name ContainerWithEnumDictionary so that it does not end in 'Dictionary' (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1711) [D:\a\NJsonSchema\NJsonSchema\src\NJsonSchema.Tests\NJsonSchema.Tests.csproj::TargetFramework=net462]