TypeScript generator: Use string type as the discriminator property type in specialized interfaces #260
Annotations
4 errors and 11 warnings
|
|
|
|
The following actions uses Node.js version which is deprecated and will be forced to run on node20: actions/checkout@v3, actions/cache@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
/home/runner/work/NJsonSchema/NJsonSchema/src/NJsonSchema.Yaml.Tests/References/YamlReferencesTests.cs(21,27): warning CA1707: Remove the underscores from member name NJsonSchema.Yaml.Tests.References.LocalReferencesTests.When_yaml_schema_has_references_it_works(string, string) (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1707) [/home/runner/work/NJsonSchema/NJsonSchema/src/NJsonSchema.Yaml.Tests/NJsonSchema.Yaml.Tests.csproj::TargetFramework=net8.0]
|
/home/runner/work/NJsonSchema/NJsonSchema/src/NJsonSchema.Yaml.Tests/References/YamlReferencesTests.cs(69,27): warning CA1707: Remove the underscores from member name NJsonSchema.Yaml.Tests.References.LocalReferencesTests.When_yaml_OpenAPI_spec_is__served_with_gzip_compression__it_works(string, string) (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1707) [/home/runner/work/NJsonSchema/NJsonSchema/src/NJsonSchema.Yaml.Tests/NJsonSchema.Yaml.Tests.csproj::TargetFramework=net8.0]
|
/home/runner/work/NJsonSchema/NJsonSchema/src/NJsonSchema.Yaml.Tests/References/YamlReferencesTests.cs(83,27): warning CA1707: Remove the underscores from member name NJsonSchema.Yaml.Tests.References.LocalReferencesTests.When_yaml_OpenAPI_spec_has_relative_external_schema_refs_in_subdirs__they_are_resolved(string) (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1707) [/home/runner/work/NJsonSchema/NJsonSchema/src/NJsonSchema.Yaml.Tests/NJsonSchema.Yaml.Tests.csproj::TargetFramework=net8.0]
|
/home/runner/work/NJsonSchema/NJsonSchema/src/NJsonSchema.Yaml.Tests/References/YamlReferencesTests.cs(38,27): warning CA1707: Remove the underscores from member name NJsonSchema.Yaml.Tests.References.LocalReferencesTests.When_yaml_OpenAPI_spec_has_external_schema_refs_they_are_resolved(string, string, string) (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1707) [/home/runner/work/NJsonSchema/NJsonSchema/src/NJsonSchema.Yaml.Tests/NJsonSchema.Yaml.Tests.csproj::TargetFramework=net8.0]
|
/home/runner/work/NJsonSchema/NJsonSchema/src/NJsonSchema.Yaml.Tests/References/YamlReferencesTests.cs(115,24): warning CA1822: Member 'GetTestDirectory' does not access instance data and can be marked as static (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1822) [/home/runner/work/NJsonSchema/NJsonSchema/src/NJsonSchema.Yaml.Tests/NJsonSchema.Yaml.Tests.csproj::TargetFramework=net8.0]
|
/home/runner/work/NJsonSchema/NJsonSchema/src/NJsonSchema.Tests/Converters/JsonExceptionConverterTests.cs(26,23): warning CA1507: Use nameof in place of string literal 'CompanyKey' (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1507) [/home/runner/work/NJsonSchema/NJsonSchema/src/NJsonSchema.Tests/NJsonSchema.Tests.csproj::TargetFramework=net8.0]
|
/home/runner/work/NJsonSchema/NJsonSchema/src/NJsonSchema.Tests/Generation/ArrayGenerationTests.cs(36,52): warning CA1825: Avoid unnecessary zero-length array allocations. Use Array.Empty<string>() instead. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1825) [/home/runner/work/NJsonSchema/NJsonSchema/src/NJsonSchema.Tests/NJsonSchema.Tests.csproj::TargetFramework=net8.0]
|
/home/runner/work/NJsonSchema/NJsonSchema/src/NJsonSchema.Tests/Generation/AttributeGenerationTests.cs(230,22): warning CA1711: Rename type name ClassWithDictionary so that it does not end in 'Dictionary' (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1711) [/home/runner/work/NJsonSchema/NJsonSchema/src/NJsonSchema.Tests/NJsonSchema.Tests.csproj::TargetFramework=net8.0]
|
/home/runner/work/NJsonSchema/NJsonSchema/src/NJsonSchema.Tests/Generation/IgnoredPropertyTests.cs(15,27): warning CA1051: Do not declare visible instance fields (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1051) [/home/runner/work/NJsonSchema/NJsonSchema/src/NJsonSchema.Tests/NJsonSchema.Tests.csproj::TargetFramework=net8.0]
|
/home/runner/work/NJsonSchema/NJsonSchema/src/NJsonSchema.Tests/Generation/IgnoredPropertyTests.cs(18,27): warning CA1051: Do not declare visible instance fields (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1051) [/home/runner/work/NJsonSchema/NJsonSchema/src/NJsonSchema.Tests/NJsonSchema.Tests.csproj::TargetFramework=net8.0]
|
This job failed
Loading