Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/movegroups #123

Merged
merged 11 commits into from
Jul 30, 2023
Merged

Feat/movegroups #123

merged 11 commits into from
Jul 30, 2023

Conversation

MKerner3
Copy link
Contributor

Description

This PR does the following:

  • Adds move group planning to the arm for trajectory execution
  • Adds a demo file to test path planning and execution within rviz
  • Allows the robot to be configured with the move group c++ interface

Fixes #111

Testing Steps

Test Case 1

  1. cd to your rover colcon
  2. colcon build
  3. . install/setup.bash
  4. ros2 launch urc_arm_moveit_config demo.launch.py

Expectation: The robot arm loaded in rviz, with the ability to move it around and execute path plans.

Design Doc

Link to Design Doc

Self Checklist

  • I have formatted my code using ament_uncrustify --reformat
  • I have tested that the new behavior works

@MKerner3 MKerner3 added area ➤ rviz area/controls Related to controls labels Jul 29, 2023
@MKerner3 MKerner3 added this to the Functional Robot Arm milestone Jul 29, 2023
@MKerner3 MKerner3 self-assigned this Jul 29, 2023
Copy link
Contributor

@harrislegobrick harrislegobrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Writing this down as it may be exclusive to my setup but is still worth writing down.

The moveit_ros_move_group fails to run when launching the demo file. This is fixed by manually running the node in a new terminal with ros2 run moveit_ros_move_group movegroup ... with the ... being specific launch parameters based on tmp files. The tmp file specifics are displayed in the terminal when running the demo file as an error.

urc_gazebo/urdf/WalliiArmV3.urdf Outdated Show resolved Hide resolved
Copy link
Member

@davidcalderon03 davidcalderon03 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GigaChad

@davidcalderon03 davidcalderon03 merged commit 27d86a2 into master Jul 30, 2023
5 checks passed
@davidcalderon03 davidcalderon03 deleted the feat/movegroups branch July 30, 2023 01:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/controls Related to controls
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Basic Arm Functionality
3 participants